Skip to content
This repository has been archived by the owner on Mar 16, 2021. It is now read-only.

TiFragmentPlugin #49

Merged
merged 8 commits into from
Jan 9, 2017
Merged

TiFragmentPlugin #49

merged 8 commits into from
Jan 9, 2017

Conversation

passsy
Copy link
Contributor

@passsy passsy commented Dec 16, 2016

Plugin for Fragments using the new TiFragmentDelegate

@passsy passsy added the plugin label Dec 16, 2016
@vRallev
Copy link
Contributor

vRallev commented Dec 16, 2016

Besides the tests it looks good, that'll make my life easier with the integration

@mayankdbit
Copy link

I was trying to use this TiFragmentPlugin and I get following error

java.lang.IllegalStateException: Do not call setRetainInstance(Boolean) on a ActivityPlugin directly. You have to call mDelegate.setRetainInstance(Boolean) or the call order of the plugins would be mixed up.
                                                                                      at com.pascalwelsch.compositeandroid.core.AbstractPlugin.verifyMethodCalledFromDelegate(AbstractPlugin.java:35)
                                                                                      at com.pascalwelsch.compositeandroid.fragment.FragmentPlugin.setRetainInstance(FragmentPlugin.java:356)
                                                                                      at com.capitalone.mobile.wallet.mvp.TiFragmentPlugin.setFragmentRetainInstance(TiFragmentPlugin.java:210)
                                                                                      at net.grandcentrix.thirtyinch.internal.TiFragmentDelegate.onCreate_afterSuper(TiFragmentDelegate.java:146)
                                                                                      at com.capitalone.mobile.wallet.mvp.TiFragmentPlugin.onCreate(TiFragmentPlugin.java:133)

passsy
passsy commented Dec 27, 2016
View reviewed changes
plugin/src/main/java/net/grandcentrix/thirtyinch/plugin/TiFragmentPlugin.java

@Override
public void setFragmentRetainInstance(final boolean retain) {
setRetainInstance(retain);
Copy link
Contributor Author

@passsy passsy Dec 27, 2016 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use getFragment.setRetainInstance(retain)

thx @mayankdbit

@StefMa
Copy link
Contributor

StefMa commented Jan 9, 2017

LGTM

@StefMa StefMa merged commit e026ec5 into master Jan 9, 2017
@StefMa StefMa deleted the feature/composite_fragments branch January 9, 2017 13:59
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
plugin Ready for Review
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@passsy @vRallev @mayankdbit @StefMa