This repository has been archived by the owner on Mar 16, 2021. It is now read-only.
RxJava2 support #54
Merged
RxJava2 support #54
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jan 6, 2017
StefMa
commented
Jan 9, 2017
| mDisposableHandler.manageViewDisposable(testObserver); | ||
| mPresenter.detachView(); | ||
|
|
||
| // Think about that. |
passsy
approved these changes
Jan 19, 2017
|
Let's add the |
|
Yeah, I am fine with that.
Feel free to merge 👍🍩
On Jan 19, 2017 5:42 PM, "Pascal Welsch" <notifications@github.com> wrote:
Let's add the deliver*ToView() in a separate PR
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#54 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AJwYe1Fegrg-rVVLPIsBIpVglGyvO52Lks5rT5KOgaJpZM4Lcd4X>
.
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RxJava2 support
This is a first draft of supporting RxJava2.
Included:
The fully helper class
RxTiPresenterDisposableHandler.A part of RxTiPresenterUtils. Currently only
isViewReady().I've created a new
rx2module which can be plugged in like the RxJava (1) module (need to be uploaded to maven of course)...TODOs
deliverLatestCacheToView()deliverLatestToView()deliverToView()