This repository has been archived by the owner on Mar 16, 2021. It is now read-only.
Manage*Subcription return Subscription now #73
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
passsy
reviewed
Mar 6, 2017
| })); | ||
| }); | ||
|
|
||
| rxSubscriptionHelper.manageViewSubscriptions(showTextSub, onButtonClickSub); |
There was a problem hiding this comment.
I'm not sure if it's useful to create local variables for the subscriptions. But I also don't like method references. Just personal preference here 🦄
passsy
approved these changes
Mar 6, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will fix #59
Nothing special here.
manageViewSubscription/disposablewill now return the givenSubscription/Disposable.manageViewSubscriptionshave introduced to add multipleSubscription/Disposable.That is a small "API change". But only on RC's.
Because in earlier 0.8 RC's we have changed the API from
manageViewSubscription(Subscription)tomanageViewSubscription(Subscription...).Not we "revertet" it to
manageViewSubscription(Subscription)but addedmanageViewSubscriptions(Subscription...)(note theShere 😉)