-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DEV] 프로그램 배포 설정 및 code test용 github action 추가 #31
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
: add sharp package using to image optimization
: add suspense component to build project
: add format, lint workflow
: remove cached option in lint command
: add delete merged branch actions and eslint checking
: bug fixed
falconlee236
requested review from
1lsang,
ldh019 and
yugenius0213
as code owners
November 5, 2024 08:56
falconlee236
changed the title
Dev/ci cd [임시]
[DEV] 프로그램 배포 설정 및 code test용 github action 추가
Nov 5, 2024
yugenius0213
approved these changes
Nov 5, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
우왓 너무 고생많으셨습니다 ~~
서버 켜지는대로 수정해서 PR 올리겠습니다 !!
yymin1022
approved these changes
Nov 5, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
조와요
Docker 컨테이너 오픈할 때 3030
포트만 열면 되는거 확인했습니다~
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
코드를 변경했습니다.
CI / CD 환경을 구축했습니다.
Description
코드 변경사항
sqoosh
대신에 실제 production 단계에서는sharp
라는 압축 프로그램을 사용하는데 그sharp
패키지를 설치했습니다.useSearchParams
를 사용할 때 , suspense라는 컴포넌트로 감싸주지 않아서 build error가 발생했고, 그 부분을 수정했습니다.-> next js에서 정의햔 규칙이라고 하네요. useSearchParams 를 사용하면 CSR을 하게 되는데 그때 렌더링 될 동안 필요한 페이지를 정의해달라고 부탁하는 것 같습니다.
CI - github action
github action으로 CI작업을 수행합니다.
CD - Jenkins
주의사항
참고자료
https://nextjs.org/docs/messages/sharp-missing-in-production
https://nextjs.org/docs/messages/missing-suspense-with-csr-bailout
https://devnm.tistory.com/m/38
https://velog.io/@chamny20/TIL-Suspense-%EC%95%8C%EC%95%84%EB%B3%B4%EA%B8%B0-%EA%B7%B8%EB%A6%AC%EA%B3%A0-Next.js-useSearchParams