Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FIX] ./src/constants/errorMessages.ts ESLint 오류 해결 #44

Merged
merged 2 commits into from
Nov 5, 2024
Merged

[FIX] ./src/constants/errorMessages.ts ESLint 오류 해결 #44

merged 2 commits into from
Nov 5, 2024

Conversation

falconlee236
Copy link
Member

Summary

github action에서 발생하는 간단한 lint 에러를 해결했습니다.

Description

github action에서 발생하는 간단한 lint 에러를 해결했습니다.

  • 파일의 맨 마지막에 공백이 하나 더 있는 에러 해결
  • 사용하지 않는 변수가 있는 lint에러를 ignore로 해결

@falconlee236
Update errorMessages.ts
5e6a62f 
 : remove unnecessary space
@falconlee236
Update ImageUpload.tsx
d6516f1 
 : add ignore lint comment
@falconlee236 falconlee236 added the fix Something isn't working label Nov 5, 2024
@falconlee236 falconlee236 added this to the 1.0.0 milestone Nov 5, 2024
@falconlee236 falconlee236 self-assigned this Nov 5, 2024
@falconlee236
Copy link
Member Author

이거는 간단한 에러니까 빨리 merge할게요

yugenius0213
yugenius0213 approved these changes Nov 5, 2024
View reviewed changes
Copy link
Collaborator

@yugenius0213 yugenius0213 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생이 많으십니다!
approve 했습니다~

@falconlee236 falconlee236 merged commit 1ec48fc into GDSC-CAU:main Nov 5, 2024
1 check failed
@falconlee236 falconlee236 deleted the fix/errorMessage-eslint branch November 5, 2024 13:51
@falconlee236 falconlee236 linked an issue Nov 5, 2024 that may be closed by this pull request
[FIX] ./src/constants/errorMessages.ts ESLint 오류 해결 #43
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yugenius0213 yugenius0213 yugenius0213 approved these changes

@1lsang 1lsang Awaiting requested review from 1lsang 1lsang is a code owner

@ldh019 ldh019 Awaiting requested review from ldh019 ldh019 is a code owner

@yymin1022 yymin1022 Awaiting requested review from yymin1022 yymin1022 is a code owner

Assignees

@falconlee236 falconlee236

Labels
fix Something isn't working
Projects
None yet
Milestone
1.0.0
Development

Successfully merging this pull request may close these issues.

[FIX] ./src/constants/errorMessages.ts ESLint 오류 해결
2 participants
@falconlee236 @yugenius0213