Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature] Toast 컴포넌트 #157

Merged
merged 31 commits into from
Oct 12, 2024
Merged

[Feature] Toast 컴포넌트 #157

merged 31 commits into from
Oct 12, 2024

Conversation

hamo-o
Copy link
Member

@hamo-o hamo-o commented Sep 3, 2024

🎉 변경 사항

  • Toast 컴포넌트를 구현합니다.
image

🚩 관련 이슈

🙏 여기는 꼭 봐주세요!

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Sep 3, 2024

🚀 storybook: https://663657b8272769a8d18a5e3f-daxhuxmftr.chromatic.com/

@hamo-o hamo-o mentioned this pull request Sep 4, 2024
Closed
@hamo-o hamo-o force-pushed the feature/toast-component branch from c7f43aa to eadf873 Compare September 15, 2024 11:03
@github-actions GitHub Actions
Copy link
Contributor

🚀 storybook: https://663657b8272769a8d18a5e3f-swhxpjstbz.chromatic.com/

@hamo-o hamo-o marked this pull request as ready for review September 15, 2024 11:14
SeieunYoo
SeieunYoo reviewed Sep 18, 2024
View reviewed changes
Copy link
Collaborator

@SeieunYoo SeieunYoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

수고 하셨습니당~~

packages/wow-ui/src/components/Toast/index.tsx Outdated Show resolved Hide resolved
packages/wow-ui/src/components/Toast/ToastProvider.tsx Outdated Show resolved Hide resolved
packages/wow-ui/src/components/Toast/index.tsx Outdated Show resolved Hide resolved
packages/wow-ui/src/components/Toast/Toast.stories.tsx Show resolved Hide resolved
packages/wow-ui/src/components/Toast/Toast.stories.tsx Outdated Show resolved Hide resolved
packages/wow-ui/src/components/Toast/Toast.stories.tsx Outdated Show resolved Hide resolved
packages/wow-ui/src/components/Toast/index.tsx Outdated Show resolved Hide resolved
@github-actions GitHub Actions
Copy link
Contributor

🚀 storybook: https://663657b8272769a8d18a5e3f-veehscypoq.chromatic.com/

ghdtjgus76
ghdtjgus76 reviewed Sep 22, 2024
View reviewed changes
Copy link
Collaborator

@ghdtjgus76 ghdtjgus76 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

수고하셨습니다!

packages/scripts/generateReactComponentFromSvg.ts Outdated Show resolved Hide resolved
packages/wow-icons/package.json Show resolved Hide resolved
packages/wow-ui/src/components/Toast/index.tsx Outdated Show resolved Hide resolved
packages/wow-ui/src/components/Toast/Toast.stories.tsx Outdated Show resolved Hide resolved
packages/wow-ui/src/components/Toast/index.tsx Outdated Show resolved Hide resolved
packages/wow-ui/src/components/Toast/ToastProvider.tsx Outdated Show resolved Hide resolved
packages/wow-ui/src/components/Toast/ToastProvider.tsx Outdated Show resolved Hide resolved
packages/wow-ui/src/components/Toast/Toast.stories.tsx Outdated Show resolved Hide resolved
@github-actions GitHub Actions
Copy link
Contributor

🚀 storybook: https://663657b8272769a8d18a5e3f-ivlpitrigb.chromatic.com/

@github-actions GitHub Actions
Copy link
Contributor

🚀 storybook: https://663657b8272769a8d18a5e3f-qyggtmoggq.chromatic.com/

SeieunYoo
SeieunYoo approved these changes Oct 3, 2024
View reviewed changes
Copy link
Collaborator

@SeieunYoo SeieunYoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

수고 많으셨습니다~~changeset 도 작성해서 배포되면 좋을 거 같습니당

ghdtjgus76
ghdtjgus76 approved these changes Oct 11, 2024
View reviewed changes
Copy link
Collaborator

@ghdtjgus76 ghdtjgus76 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

수고하셨어요! changeset 작성해서 배포하면 될 거 같아요

hamo-o added 20 commits October 12, 2024 23:20
@hamo-o
fix: 토스트가 여러개일 때 레이아웃 조정
b27b03c
@hamo-o
chore: useToast 빌드 포함
b8f1eeb
@hamo-o
fix: color contrast 검사 통과
438a278
@hamo-o
feat: 토스트 duration 받을 수 있도록 추가
cfbcf15
@hamo-o
feat: overlay zIndex 토큰 추가
d319141
@hamo-o
refactor: zIndex 토큰 사용하도록 변경
403b7af
@hamo-o
feat: 공통 타입 파일 내보내도록 스크립트 수정
a0ab098
@hamo-o
refactor: TypeIconComponent 네이밍 변경 및 공통 prop 빼기
7e00b06
@hamo-o
fix: 토스트 트리거 존재하는 경우 스토리 추가, 토스트가 없을 때 오버레이 공간 차지하지 않도록 조건부 렌더링
689cc2a
@hamo-o
docs: ToastProvider 내용 안내
301b804
@hamo-o
docs: 스토리북 radio 옵션 추가 및 기본 컴포넌트 변경
71d2fe9
@hamo-o
feat: 토스트 컴포넌트 제거 이후 실행되는 함수 추가
786e1bc
@hamo-o
feat: docs에도overlay 토큰 추가
fa6a9f2
@hamo-o
fix: type -> rightIcon 네이밍 변경
cefebe9
@hamo-o
docs: 스토리북 설명 및 타이틀 변경
73eee2d
@hamo-o
fix: 스크립트 content 변수 네이밍 변경
3f5ca3b
@hamo-o
fix: icon prop 불리언으로 수정
e51aa8e
@hamo-o
refactor: 현재 시각 대신 uuid로 토스트 id 지정
1e702e6
@hamo-o
feat: 정규식 입력 시 해당 정규식을 만족하는 아이디를 가진 토스트만 보여주기
1d800bd
@hamo-o
chore: changeset 작성
ed47550
@hamo-o hamo-o force-pushed the feature/toast-component branch from 66382cb to ed47550 Compare October 12, 2024 14:22
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Oct 12, 2024

🦋 Changeset detected

Latest commit: ed47550

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 4 packages
Name Type
wowds-tokens Patch
wowds-theme Patch
wowds-icons Patch
wowds-ui Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions GitHub Actions
Copy link
Contributor

🚀 storybook: https://663657b8272769a8d18a5e3f-ptwlmnvect.chromatic.com/

@hamo-o hamo-o merged commit 185475a into main Oct 12, 2024
3 checks passed
@hamo-o hamo-o deleted the feature/toast-component branch October 12, 2024 14:28
@SeieunYoo SeieunYoo linked an issue Oct 17, 2024 that may be closed by this pull request
[Feature] Toast 컴포넌트 구현 #155
Closed
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SeieunYoo SeieunYoo SeieunYoo approved these changes

@ghdtjgus76 ghdtjgus76 ghdtjgus76 approved these changes

@eugene028 eugene028 Awaiting requested review from eugene028 eugene028 is a code owner

Assignees

@hamo-o hamo-o

Labels
👩‍💻 리뷰 남겨주세요!
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Feature] Toast 컴포넌트 구현
3 participants
@hamo-o @ghdtjgus76 @SeieunYoo