feat: photo album search and improved album layout #1943
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Both now use `nav-tabs` and when a year is selected from the dropdown, both the dropdown _and_ the year are now marked as active. This is very minor but should make it easier to see what you are looking at as the year is not necessary displayed on the page itself.
Allows users to search for albums. The albums will be grouped by year and only albums a user has access to are shown (i.e. graduates see less).
tomudding
force-pushed
the
feature/photo-album-search
branch
from
1f7ccc9 to
478033e
Compare
tomudding
force-pushed
the
feature/photo-album-search
branch
from
478033e to
3e8cf8c
Compare
github-actions bot
added a commit
that referenced
this pull request
Dec 13, 2024
Tom Udding: Merge pull request #1943 from tomudding/feature/photo-album-search feat: photo album search and improved album layout Co-authored-by: tomudding <tomudding@users.noreply.github.com>
github-actions bot
added a commit
to tomudding/gewisweb
that referenced
this pull request
Dec 13, 2024
Tom Udding: Merge pull request GEWIS#1943 from tomudding/feature/photo-album-search feat: photo album search and improved album layout Co-authored-by: tomudding <tomudding@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
It is now possible to search for albums by their name. They will be displayed per year, if no album exists containing the search query the year will not be shown. Filtering is taken into account for special situations (such as for
graduates).This also moves albums to the improved grid and card layout from GH-1934 and fixes an issue where it was not clear what year was selected in the year selector navigation bar (for both activities and albums).
Also removes some unused code.
Related issues/external references
Closes GH-1815.
Types of changes