Feature/native android camera component #208
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Force default front camera. - Crop image after stillshot. - Set crop aspect ratio to 9:16
- Remove unnecessary buttons. - Add flip horizontal button. - Remove image preview screen. - Fix taking photos on some devices.
- Video preview now showed full screen
- Fix landscape camera crash (disable landscape)
….com/GLLU/mobile into feature/nativeAndroidCameraComponent # Conflicts: # android/app/src/main/java/com/gllu/MainApplication.java # android/app/src/main/java/com/gllu/modules/CameraUtils.java
shirbr510
added a commit
that referenced
this pull request
May 14, 2017
* upgraded to RN 0.43.4 with broken dependencies * Fixed style issues cause by native-base in some components (will be fully fixed in future commit) * deleted ‘home’ page (was not used anywhere) * Removed some native-base redundant form components * handled some parts of sign-in and splash screen to be “native-base less” * Made BadNavigationScreen into a Functional Component * Fixed native-base issues in activation page * fixed native-base issues in signup page * Replaced all the native-base view and text with react-native view and text * Animations look AWESOME * Refactored most of the flow of uploadLook * tiny refactor for brands autocomplete * Fixed native-base style issues in uploadLook (all stages) * fixed native-base issues with profilescreen & settings screen * Fixed broken react-native-video * fixed disappearing list views * Updated package son for RN0.43 * Removed duplicate permissions from AndroidManifest * fixed ‘next’ button style in uploadLookScreen * Added missing binding in addItemScreen constructor * fixed clear button * Fixed gif issue (facebook/react-native#13345) * Aligned Gllu.Button text * aligned report and back button in profile screen * fixed LikeView alignment * Fixed incorrect styling of LikeView * fix look screen keys bug * Removed weird gap in bottom of comments view * ios changes for rn0.40 * fixed empty view style issues in Notifications/Followers & Following screens * App loads react modules correctly. (Still have to deal with Flurry bug) * Fixed iOS flurry bug (resolved react-native-config version straight form sources instead of fork) * fixed missing config files in build.gradle * Feature/native android camera component (#208) * - Integrate camera native component * -Change default record circle button. - Force default front camera. - Crop image after stillshot. - Set crop aspect ratio to 9:16 * - Change cropper action bar background. - Remove unnecessary buttons. - Add flip horizontal button. - Remove image preview screen. - Fix taking photos on some devices. * - Fix video stretching. - Video preview now showed full screen * Remove from gitignore * - Remove rotate button. - Fix landscape camera crash (disable landscape) * - Add trimer library * Trim Video settings * Integrate video trimming in entire flow
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.