Create mechanics for some queries of the broker to reset on changes #1617
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…dd counter query.
Co-authored-by: Philip Top <top1@llnl.gov> Co-authored-by: HELICS-bot <HELICS-bot@users.noreply.github.com>
|
Addresses Issue #1610 |
nightlark
reviewed
Oct 2, 2020
Co-authored-by: Ryan Mast <nightlark@users.noreply.github.com>
trevorhardy
approved these changes
Oct 2, 2020
nightlark
approved these changes
Oct 2, 2020
phlptp
added a commit
that referenced
this pull request
Oct 27, 2020
…1617) * Create mechanics for some queries of the broker to reset on changes add counter query. * Automated formatting of repo files (#1618) Co-authored-by: Philip Top <top1@llnl.gov> Co-authored-by: HELICS-bot <HELICS-bot@users.noreply.github.com> * fix static analyzer warnings * Apply suggestions from code review Co-authored-by: Ryan Mast <nightlark@users.noreply.github.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: HELICS-bot <HELICS-bot@users.noreply.github.com> Co-authored-by: Ryan Mast <nightlark@users.noreply.github.com> # Conflicts: # src/helics/core/CommonCore.cpp # src/helics/core/CoreBroker.cpp
phlptp
added a commit
that referenced
this pull request
Nov 6, 2020
…1617) * Create mechanics for some queries of the broker to reset on changes add counter query. * Automated formatting of repo files (#1618) Co-authored-by: Philip Top <top1@llnl.gov> Co-authored-by: HELICS-bot <HELICS-bot@users.noreply.github.com> * fix static analyzer warnings * Apply suggestions from code review Co-authored-by: Ryan Mast <nightlark@users.noreply.github.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: HELICS-bot <HELICS-bot@users.noreply.github.com> Co-authored-by: Ryan Mast <nightlark@users.noreply.github.com> # Conflicts: # src/helics/core/CommonCore.cpp # src/helics/core/CoreBroker.cpp
phlptp
added a commit
that referenced
this pull request
Nov 6, 2020
* #1380 (#1600) Co-authored-by: Vyacheslav Barsuk <vbarsuk@nrel.gov> * add a message clear operation for Message to the C++/C/C++98 APi's (#1622) * add a message clear operation for Message to the C++/C/C++98 APi's * Automated formatting of repo files (#1623) Co-authored-by: Philip Top <top1@llnl.gov> Co-authored-by: HELICS-bot <HELICS-bot@users.noreply.github.com> * Update src/helics/shared_api_library/MessageFederate.h Co-authored-by: Ryan Mast <nightlark@users.noreply.github.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: HELICS-bot <HELICS-bot@users.noreply.github.com> Co-authored-by: Ryan Mast <nightlark@users.noreply.github.com> # Conflicts: # src/helics/core/core-data.hpp # src/helics/shared_api_library/MessageFederateExport.cpp * add a requested time field to the current_time query result (#1619) * add a requested time field to the query result and fix a bug that could potentially cause deadlock if particular queries were made while a federate was using an async call. * Automated formatting of repo files (#1620) Co-authored-by: Philip Top <top1@llnl.gov> Co-authored-by: HELICS-bot <HELICS-bot@users.noreply.github.com> * Update docs/user-guide/queries.md Co-authored-by: Ryan Mast <nightlark@users.noreply.github.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: HELICS-bot <HELICS-bot@users.noreply.github.com> Co-authored-by: Ryan Mast <nightlark@users.noreply.github.com> * Create mechanics for some queries of the broker to reset on changes (#1617) * Create mechanics for some queries of the broker to reset on changes add counter query. * Automated formatting of repo files (#1618) Co-authored-by: Philip Top <top1@llnl.gov> Co-authored-by: HELICS-bot <HELICS-bot@users.noreply.github.com> * fix static analyzer warnings * Apply suggestions from code review Co-authored-by: Ryan Mast <nightlark@users.noreply.github.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: HELICS-bot <HELICS-bot@users.noreply.github.com> Co-authored-by: Ryan Mast <nightlark@users.noreply.github.com> # Conflicts: # src/helics/core/CommonCore.cpp # src/helics/core/CoreBroker.cpp * Issue #1548 (#1642) * add tests and additional strings for verification of the index translations * specify .*JPG is binary * Automated formatting of repo files (#1643) Co-authored-by: Philip Top <top1@llnl.gov> Co-authored-by: HELICS-bot <HELICS-bot@users.noreply.github.com> * add missing include * fix some formatting issues * fix some missing underscores Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: HELICS-bot <HELICS-bot@users.noreply.github.com> # Conflicts: # docs/introduction/hello-world-VS.md # docs/introduction/hello-world.md # src/helics/application_api/FederateInfo.cpp # tests/helics/shared_library/CMakeLists.txt * C api query callback (#1634) * Add a query callback for the C api * add queryCallback to the C api including some additional tests * Automated formatting of repo files (#1635) Co-authored-by: Philip Top <top1@llnl.gov> Co-authored-by: HELICS-bot <HELICS-bot@users.noreply.github.com> * Fix static analyzer issues * Automated formatting of repo files (#1636) Co-authored-by: Philip Top <top1@llnl.gov> Co-authored-by: HELICS-bot <HELICS-bot@users.noreply.github.com> * fix seg fault * Automated formatting of repo files (#1637) Co-authored-by: Philip Top <top1@llnl.gov> Co-authored-by: HELICS-bot <HELICS-bot@users.noreply.github.com> * Fix some codacy and asan errors in the queryTests * update comment spacing * Automated formatting of repo files (#1638) Co-authored-by: Philip Top <top1@llnl.gov> Co-authored-by: HELICS-bot <HELICS-bot@users.noreply.github.com> * Apply suggestions from code review Co-authored-by: Ryan Mast <nightlark@users.noreply.github.com> * Update Federate.hpp Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: HELICS-bot <HELICS-bot@users.noreply.github.com> Co-authored-by: Ryan Mast <nightlark@users.noreply.github.com> # Conflicts: # src/helics/core/CommonCore.cpp # src/helics/core/Core.hpp * merge in a series of fixes from Helics 2 into HELICS 3 * Automated formatting of repo files (#1694) Co-authored-by: Philip Top <top1@llnl.gov> Co-authored-by: HELICS-bot <HELICS-bot@users.noreply.github.com> * fix broken tests Co-authored-by: Slava Barsuk <50117112+vbarsuk@users.noreply.github.com> Co-authored-by: Vyacheslav Barsuk <vbarsuk@nrel.gov> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: HELICS-bot <HELICS-bot@users.noreply.github.com> Co-authored-by: Ryan Mast <nightlark@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
If merged this pull request will add a reset counter to some of the broker queries, dependecy_graph, data_flow_graph,and some others.
Proposed changes