Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Develop #2433

Merged
merged 44 commits into from
Sep 15, 2022
Merged

Develop #2433

merged 44 commits into from
Sep 15, 2022

Conversation

phlptp
Copy link
Member

@phlptp phlptp commented Sep 15, 2022

Summary

If merged this pull request will merge to main for the 3.3 release

pre-commit-ci bot and others added 30 commits June 20, 2022 18:21
@pre-commit-ci
[pre-commit.ci] pre-commit autoupdate
a264c41 
updates:
- [github.com/pre-commit/mirrors-prettier: v2.6.2 → v2.7.1](pre-commit/mirrors-prettier@v2.6.2...v2.7.1)
- [github.com/pre-commit/mirrors-clang-format: v14.0.4-1 → v14.0.5](pre-commit/mirrors-clang-format@v14.0.4-1...v14.0.5)
@phlptp
Merge pull request #2381 from GMLC-TDC/pre-commit-ci-update-config
3b4cafc 
[pre-commit.ci] pre-commit autoupdate
@phlptp @pre-commit-ci
long_file_name_removal (#2379)
e158de2 
* remove the very long file name from the source directory and have it be automatically generated by cmake

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
@phlptp @pre-commit-ci
custom_translator_test_bug (#2383)
967eb35 
* fix a bug in the ADD_PUBLISHER code that was causing a sporadic failure in the custom_translator tests

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
@phlptp @pre-commit-ci
test case fixes (#2380)
6e3ea52 
* Try to fix a few of the failing test cases potentially related to use of std::async

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* fix another use of async in tests

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
@phlptp @pre-commit-ci @nightlark
Remove external filesystem (#2378)
9d3dc2b 
* switch to use std::filesystem

* replace the CLI11 back where it was

* update the pipelines to match new minimums

* update namespace usage

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* update some pipelines and pre-commit checks

* more string_view operations on the tests

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* more string_view work and addressing new cpplint issues

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* fix some tests

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* fix translator update error

* adjust precommit checks

* Update CHANGELOG.md

Co-authored-by: Ryan Mast <3969255+nightlark@users.noreply.github.com>

* more string_view

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* adjust the compiler flags to account for new minimums and add fs library for gcc 8

* update changelog to minimum gcc at 8.1

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* Update src/helics/shared_api_library/internal/api_objects.h

Co-authored-by: Ryan Mast <3969255+nightlark@users.noreply.github.com>

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Ryan Mast <3969255+nightlark@users.noreply.github.com>
@phlptp @pre-commit-ci @nightlark
Async time coordinator (#2384)
e081af7 
* add an Asynchronous time coordinator and clean the flags which were becoming a bit too overloaded to be clear

* add some basic tests for async time coordinator

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* fix clang tidy issues

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* add more/clearer documentation and some additional enumeration values

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* Apply suggestions from code review

Co-authored-by: Ryan Mast <3969255+nightlark@users.noreply.github.com>

* Update src/helics/core/BrokerBase.cpp

Co-authored-by: Ryan Mast <3969255+nightlark@users.noreply.github.com>

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Ryan Mast <3969255+nightlark@users.noreply.github.com>
@nightlark
Increase minimum macOS target version to 10.15 (#2389)
8e7c52f
@pre-commit-ci
[pre-commit.ci] pre-commit autoupdate (#2391)
71c11bb 
updates:
- [github.com/psf/black: 22.3.0 → 22.6.0](psf/black@22.3.0...22.6.0)
- [github.com/pre-commit/mirrors-clang-format: v14.0.5 → v14.0.6](pre-commit/mirrors-clang-format@v14.0.5...v14.0.6)

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
@phlptp @pre-commit-ci
Dailies tests (#2392)
bbe05c5 
* update the docker images for the octave and no_zmq tests

* try a tweak with the octave maps

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
@pre-commit-ci
[pre-commit.ci] pre-commit autoupdate (#2396)
ab1aa0f 
updates:
- [github.com/Lucas-C/pre-commit-hooks: v1.2.0 → v1.3.0](Lucas-C/pre-commit-hooks@v1.2.0...v1.3.0)

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
@phlptp @pre-commit-ci @nightlark
Interface aliases (#2387)
37ffa36 
* start to work on the interface aliases functionality

* add HandleManagerTests and work on aliases in the HandleManager

* add support in core/broker for interface aliases

* addAlias functions to config and other API calls

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* add more clarity in errors

* rework the alias management structure to force it to be unique

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* cpplint updates

* add additional alias tests

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* add file tests with aliases

* add documentation

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* update config file

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* fix precommit issue

* Apply suggestions from code review

Co-authored-by: Ryan Mast <3969255+nightlark@users.noreply.github.com>

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* more suggested fixes from code review

* Update docs/user-guide/advanced_topics/advanced_topics_index.md

Co-authored-by: Ryan Mast <3969255+nightlark@users.noreply.github.com>

* change the add alias number

* update method name to match style guide

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Ryan Mast <3969255+nightlark@users.noreply.github.com>
@phlptp @pre-commit-ci
Try to clear up some of the remaining sporadic failures (#2394)
86c84c4 
* Try to clear up some of the remaining sporadic failures

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* check about deleting file first

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* fix some warnings and try again on logging_file tests

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
@kdheepak @phlptp @nightlark
Add CORS support (#2398)
ce13313 
* Checkout submodules using actions/checkout instead of CMake for Code Coverage build

* feat: Add CORS support

Co-authored-by: Philip Top <top1@llnl.gov>
Co-authored-by: Ryan Mast <mast9@llnl.gov>
@phlptp @pre-commit-ci
Update utilities (#2399)
19f225d 
* Update the utilities library to 0.4

* make some adjustement for new utilities methods

* update clang-tidy warnings

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
@kdheepak @pre-commit-ci
Fix swagger docs (#2401)
5b34d50 
* fix: Update swagger docs

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
@phlptp @pre-commit-ci
Update gtest (#2400)
48914d2 
* update google test to latest release and add some new CI builds for C++20 and 23

* fix some clang warnings and add some additional warning flags

* more warning fixes

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* update fmtlib to 9.0.0

* try to fix C++20 VS2022 issue

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* clang-tidy fixes

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* fix some MSVC static analyzer warnings

* clang-tidy

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
@phlptp @pre-commit-ci
EndpointData refactor (#2403)
e68f16b 
* try to make the code structures for endpoint and inputs more similar for callback in the application API.

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
@phlptp @pre-commit-ci
add an HELICS_STATE_UNKNOWN result to the helicsFederateGetState (#2407)
bc4d335 
* add an HELICS_STATE_UNKNOWN result to the helicsFederateGetState

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
@pre-commit-ci
[pre-commit.ci] pre-commit autoupdate (#2409)
613b1dc 
updates:
- [github.com/jumanjihouse/pre-commit-hooks: 2.1.6 → 3.0.0](jumanjihouse/pre-commit-hooks@2.1.6...3.0.0)

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
@phlptp @pre-commit-ci @nightlark
Test resolve (#2410)
76f45c0 
* update some naming and try to do a bit more debugging on the failing reroute test

* make a tweak to the iteration control and fix a potential issue when switching between NO_ITERATIONS and ITERATE_IF_NEEDED

* update the process for TIMEOUT_DISCONNECT

* Update src/helics/core/GlobalTimeCoordinator.cpp

Co-authored-by: Ryan Mast <3969255+nightlark@users.noreply.github.com>

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Ryan Mast <3969255+nightlark@users.noreply.github.com>
@phlptp @pre-commit-ci
Char type (#2406)
37836de 
* Move the HELICS_DATA_TYPE_CHAR into the enumeration so it doesn't make things weird in the API's

* update the backup files

* fix some missed STRING types

* fix a few missed cases of initializing a string_view with a string object by default

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
@phlptp @nightlark
Publish check (#2393)
3adb14b 
* Add a check on publication flags and a time restriction flag

* update publish check

* more frozen maps and convert frozen maps to use std::string_view

* add more interface options and controls

* add error check for endpoint connections

* add time restriction and change detection for inputs

* update the PublicationInfo to use a SmallBuffer instead of std::string to match other uses

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* buffer_data now sends data on subscribe after init

* move some code from InterfaceInfo.cpp to individual interfaceInfo types

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* Update src/helics/core/PublicationInfo.hpp

Co-authored-by: Ryan Mast <3969255+nightlark@users.noreply.github.com>
@nightlark
Add HELICS_DISABLE_C_SHARED_LIB to CMake Options (#2414)
86b1bcd 
* Add HELICS_DISABLE_C_SHARED_LIB to CMake Options

* Reword HELICS_DISABLE_C_SHARED_LIB description

* Remove HELICS_BUILD_MATLAB_INTERFACE option -- switched to matHELICS
@nightlark @pre-commit-ci
Clean-up CI files and documentation related to Travis (#2415)
226ab49 
* Clean-up some outdated Travis CI related things

* Update some outdated documentation that mentioned Travis CI

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
@nightlark
Add encryption feature to vcpkg support (#2417)
6e52996 
* Add encryption feature to vcpkg.json to install OpenSSL dependency

* Add vcpkg_installed directory to .gitignore
@trevorhardy @nightlark @pre-commit-ci
Docs v3.3 (#2420)
25c3ebc 
* Add matHELICS in API reference

* Update installation guide

* Fix bad table in queries.md

* Update to install sphinxcontrib-mermaid

* Update to use static image in installation flowchart

Image is output of mermaid diagramming markup. Ryan is debugging the extension in sphinx/RTD.

* Bump up the priority for including mermaid.js

* Change mermaid js priority to 499 and remove (unused) nbsphinx extension

* Update installation flowchart to use mermaid markup

* Change installation flowchart direction to help it fit on the page better

* Update installation flowchart to use subgraphs for a better layout

* Correct language for HELICS_HANDLE_OPTION_STRICT_TYPE_CHECKING in Config Options Reference

* Add page in RTD that links to the examples in supported languages

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* Add note for C# on installing swig using pip/choco

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* Update docs/user-guide/installation/index.md

Co-authored-by: Ryan Mast <3969255+nightlark@users.noreply.github.com>

* Add link to build-from-source on the installation graph

* Update docs/user-guide/installation/index.md

* Adding HELICS theming to install diagram

Still can't get rid of the crazy margins, though. If you set "useMaxWidth" to "false" the diagram fills the whitespace but bleeds off the edge of the page. Its clear that the space reserved on the page is for a diagram this size but the rendered image ends up being smaller.

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

Co-authored-by: Ryan Mast <3969255+nightlark@users.noreply.github.com>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
@nightlark
Change macOS Azure CI images to XCode 13 on macOS 12 and XCode 11 on …
c3e7529 
…macOS 11 (#2416)
@phlptp
Update fmtlib and asio to new releases (#2425)
266c10b
@phlptp
Test support for boost 1.80, and CMake 3.24 (#2426)
5c2d985
phlptp and others added 11 commits September 6, 2022 08:49
@phlptp @pre-commit-ci @nightlark
update precommit files and add an ignore file for spelling (#2428)
f0f1891 
* update precommit files and add an ignore file for spelling

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* fix some codacy warnings

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* Update docs/man/federate-apps-common-options.adoc

Co-authored-by: Ryan Mast <3969255+nightlark@users.noreply.github.com>

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Ryan Mast <3969255+nightlark@users.noreply.github.com>
@phlptp @pre-commit-ci @nightlark
add a command interface to generate/clear time barriers (#2427)
025c31d 
* add a command interface to generate/clear time barriers
fix the command interface in the C++98 API
update docs
add query to get the current barriers

* Apply suggestions from code review

Co-authored-by: Ryan Mast <3969255+nightlark@users.noreply.github.com>

* Update docs/user-guide/advanced_topics/commandInterface.md

Co-authored-by: Ryan Mast <3969255+nightlark@users.noreply.github.com>

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Ryan Mast <3969255+nightlark@users.noreply.github.com>
@phlptp @pre-commit-ci @nightlark
Index Groups (#2429)
7778197 
* Add support for an index group parameter to allow users direct influence of the federateID, which can in a few select cases eliminate a source of randomness in ordering

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* fix clang tidy warnings

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* Update FederateInfo.cpp

clang tidy fixes

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* Apply suggestions from code review

Co-authored-by: Ryan Mast <3969255+nightlark@users.noreply.github.com>

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Ryan Mast <3969255+nightlark@users.noreply.github.com>
@nightlark
Disable arm32 builds on Drone Cloud (#2430)
99d6cd8 
Drone Cloud no longer has arm32 servers; unknown if they will be able to find new ones.
See https://community.harness.io/t/drone-cloud-arm-builds-step-stuck-pending-forever/12437/3 for details.
@phlptp @pre-commit-ci
@trevorhardy @nightlark
Callback federate (#2422)
36b9500 
* add the structure for a callback federate

* add the structure for a callback federate

* update the callback federate API

* more test working for callbacks

* callback operations complete

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* more tests

* add a few more tests and some documentation.

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* fix compile errors/warnings

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* fix cpplint warnings

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* Update Notes.md

* Update CallbackFederate.md

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* Update callbacks.md

* add C library tests

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* update backup files

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* fix build errors and warnings for mac builds

* Apply suggestions from code review

Co-authored-by: Ryan Mast <3969255+nightlark@users.noreply.github.com>

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* warning fixes and code suggestions

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Trevor Hardy <trevor.hardy@pnnl.gov>
Co-authored-by: Ryan Mast <3969255+nightlark@users.noreply.github.com>
@phlptp @pre-commit-ci @nightlark
Webserver updates (#2424)
e8d53a7 
* change the default webserver port and add easier external interfacing capability.

* webserver now returns a broker structure on successful creation of a broker

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* update the helicsBroker to have the same argument for the broker server as for the broker

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* fix clang-tidy warnings

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* Apply suggestions from code review

Co-authored-by: Ryan Mast <3969255+nightlark@users.noreply.github.com>

* Update docs/user-guide/advanced_topics/environment_variables.md

Co-authored-by: Ryan Mast <3969255+nightlark@users.noreply.github.com>

* address issues in code-review

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Ryan Mast <3969255+nightlark@users.noreply.github.com>
@phlptp @nightlark
@trevorhardy @pre-commit-ci
main doc changes (#2413)
8719496 
* Checkout submodules using actions/checkout instead of CMake for Code Coverage build

* Updating documentation due to helics_cli moving to PyHELICS (#2405)

* Updating documentation due to helics_cli moving to PyHELICS

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>

* Change macOS Azure CI images to XCode 13 on macOS 12 and XCode 11 on macOS 11 (#2421)

Co-authored-by: Ryan Mast <mast9@llnl.gov>
Co-authored-by: Trevor Hardy <trevor.hardy@pnnl.gov>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Ryan Mast <3969255+nightlark@users.noreply.github.com>
@eranschweitzer @pre-commit-ci
Improved iteration example documentation. (#2418)
179beb4 
* Improved iteration example documentation.

Added some more background on what iteration is doing
as well as example plots on what happens in the example
if it is "turned off".

Also so other minor fixes to the text.

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
@phlptp @pre-commit-ci @nightlark
Maxtime tests (#2432)
6b2105d 
* Add additional test around max time and time advancements

* add a capture of previous grant

* clean up some code around the timeProcessing, add new return result to enable some additional checks later on.

* Try a fix for the sequencing for endpoints

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* fix static analysis warnings.

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* Update src/helics/core/TimeDependencies.hpp

Co-authored-by: Ryan Mast <3969255+nightlark@users.noreply.github.com>

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Ryan Mast <3969255+nightlark@users.noreply.github.com>
@phlptp @pre-commit-ci
@trevorhardy @nightlark
Update documents for the 3.3.0 release (#2431)
b737e4b 
* Update documents for the 3.3.0 release

* Update orchestration.md

Co-authored-by: Ryan Mast <3969255+nightlark@users.noreply.github.com>

* update changelog with additional fix and more clarification and links

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* Apply suggestions from code review

Co-authored-by: Ryan Mast <3969255+nightlark@users.noreply.github.com>

* update wording on philosophy statement

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Trevor Hardy <trevor.hardy@pnnl.gov>
Co-authored-by: Ryan Mast <3969255+nightlark@users.noreply.github.com>
@phlptp
Merge remote-tracking branch 'remotes/origin/main' into main_merger
852b4ae
@phlptp
Copy link
Member Author

phlptp commented Sep 15, 2022

@trevorhardy take a loot at the changes to the Readme, otherwise everything else is code changes that have been reviewed previously.

@phlptp
Copy link
Member Author

phlptp commented Sep 15, 2022

it looks like there is a race condition in the callback federate operations. I took a look and I don't think it is a critical one. It will be fixed but it amounts to a race condition on a data field that doesn't get used later in the case of callback federates, so I am comfortable with leaving it in the release since callback federates are considered in Beta for this release.

trevorhardy
trevorhardy approved these changes Sep 15, 2022
View reviewed changes
docs/man/manpage_out/helics_app-clone.1 Outdated Show resolved Hide resolved
phlptp and others added 2 commits September 15, 2022 10:51
@phlptp @pre-commit-ci
add the bcrypt library to all win32 builds (#2435)
e81d584 
* add the bcrypt library to all win32 builds

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
@nightlark @pre-commit-ci
Disable VCPKG_ROOT in GHA and Azure builds (#2436)
58f44b6 
* Unset VCPKG_ROOT for builds in GitHub Actions workflows

* Bump macOS SDK version for benchmark package build

* Disable use of VCPKG_ROOT on Azure Pipelines as well

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* Remove publishing of build folder as an artifact on Windows builds

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
@phlptp phlptp merged commit 2a8858d into main Sep 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@trevorhardy trevorhardy trevorhardy approved these changes

@nightlark nightlark nightlark approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@phlptp @nightlark @trevorhardy @kdheepak @eranschweitzer