Misc. updates

GMOD · Aug 12, 2024 · ce52e14 · ce52e14
1 parent fab5c5f
commit ce52e14
Show file tree

Hide file tree

Showing 7 changed files with 4 additions and 10 deletions.
diff --git a/packages/apollo-mst/src/index.ts b/packages/apollo-mst/src/index.ts
@@ -1,5 +1,4 @@
 export * from './AnnotationFeatureModel'
-export * from './AnnotationFeatureModel'
 export * from './ApolloAssembly'
 export * from './ApolloRefSeq'
 export * from './CheckResult'
diff --git a/packages/apollo-shared/src/GFF3/gffReservedKeys.ts b/packages/apollo-shared/src/GFF3/gffReservedKeys.ts
@@ -42,7 +42,7 @@ export const gffToInternal: Record<GFFReservedAttribute, GFFInternalAttribute> =
 export function isGFFReservedAttribute(
   attribute: string,
 ): attribute is GFFReservedAttribute {
-  return gffToInternal[attribute as GFFReservedAttribute] !== undefined
+  return attribute in gffToInternal
 }
 
 export const internalToGFF: Record<GFFInternalAttribute, GFFReservedAttribute> =

diff --git a/packages/apollo-shared/src/util.ts b/packages/apollo-shared/src/util.ts
@@ -1,4 +1,3 @@
-/* eslint-disable unicorn/no-nested-ternary */
 /* eslint-disable @typescript-eslint/no-unsafe-assignment */
 import { AnnotationFeatureSnapshot } from '@apollo-annotation/mst'
 import { GFF3Feature } from '@gmod/gff'

diff --git a/packages/jbrowse-plugin-apollo/src/LinearApolloDisplay/stateModel/getGlyph.ts b/packages/jbrowse-plugin-apollo/src/LinearApolloDisplay/stateModel/getGlyph.ts
@@ -1,4 +1,3 @@
-/* eslint-disable @typescript-eslint/no-unsafe-member-access */
 import { AnnotationFeature } from '@apollo-annotation/mst'
 
 import { BoxGlyph, GeneGlyph, GenericChildGlyph } from '../glyphs'

diff --git a/packages/jbrowse-plugin-apollo/src/TabularEditor/HybridGrid/Feature.tsx b/packages/jbrowse-plugin-apollo/src/TabularEditor/HybridGrid/Feature.tsx
@@ -1,8 +1,7 @@
 /* eslint-disable @typescript-eslint/use-unknown-in-catch-callback-variable */
 /* eslint-disable unicorn/no-nested-ternary */
 /* eslint-disable @typescript-eslint/unbound-method */
-/* eslint-disable @typescript-eslint/no-unsafe-assignment */
-/* eslint-disable @typescript-eslint/no-unsafe-member-access */
+
 import { AnnotationFeature } from '@apollo-annotation/mst'
 import { AbstractSessionModel } from '@jbrowse/core/util'
 import { observer } from 'mobx-react'

diff --git a/packages/jbrowse-plugin-apollo/src/components/DeleteFeature.tsx b/packages/jbrowse-plugin-apollo/src/components/DeleteFeature.tsx
@@ -1,5 +1,3 @@
-/* eslint-disable @typescript-eslint/no-unsafe-assignment */
-/* eslint-disable @typescript-eslint/no-unsafe-member-access */
 /* eslint-disable @typescript-eslint/no-misused-promises */
 import { AnnotationFeature } from '@apollo-annotation/mst'
 import { DeleteFeatureChange } from '@apollo-annotation/shared'

diff --git a/packages/jbrowse-plugin-apollo/src/components/OpenLocalFile.tsx b/packages/jbrowse-plugin-apollo/src/components/OpenLocalFile.tsx
@@ -32,7 +32,7 @@ export interface RefSeqInterface {
 }
 
 export function OpenLocalFile({ handleClose, session }: OpenLocalFileProps) {
-  const { addApolloTrackConfig, apolloDataStore } = session
+  const { apolloDataStore } = session
   const { addAssembly, addSessionAssembly, assemblyManager, notify } =
     session as unknown as AbstractSessionModel & {
       // eslint-disable-next-line @typescript-eslint/ban-types
@@ -104,7 +104,7 @@ export function OpenLocalFile({ handleClose, session }: OpenLocalFileProps) {
     const a = await assemblyManager.waitForAssembly(assemblyConfig.name)
     if (a) {
       // @ts-expect-error MST type coercion problem?
-      addApolloTrackConfig(a)
+      session.addApolloTrackConfig(a)
       notify(`Loaded GFF3 ${file.name}`, 'success')
     } else {
       notify(`Error loading GFF3 ${file.name}`, 'error')