Remove binary-parser usage #137
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cmdcolin
force-pushed
the
no_binary_parser
branch
from
b04ee7c to
5d0b6e3
Compare
cmdcolin
force-pushed
the
no_binary_parser
branch
from
5d0b6e3 to
c5178f3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR replaces all usages of binary-parser with plain buffer parsing
The binary-parser package was problematic because it's use of eval triggers CSP warnings on webpages
CSP is a new method of securing webpages https://developer.mozilla.org/en-US/docs/Web/HTTP/CSP
some small bonuses are improved typescript, and not having to maintain @gmod/binary-parser (similar work would need to be done to bbi-js and twobit-js to fully remove) and potentially faster code (not measured yet)
some small downsides are reduced readability due to manually managed byte offsets