Fix where modules fail to compile e.g. not-a-module

GMOD · Feb 6, 2018 · 56af3e3 · 56af3e3
1 parent 8f42970
commit 56af3e3
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 3 deletions.
diff --git a/src/JBrowse/Browser.js b/src/JBrowse/Browser.js
@@ -322,9 +322,7 @@ initPlugins: function() {
 
         // fire the "all plugins done" deferred when all of the plugins are done loading
         (new DeferredList( pluginDeferreds ))
-            .then( function() {
-            deferred.resolve({success: true});
-        });
+            .then( function() { deferred.resolve({success: true}); });
 
         require( {
                      packages: array.map( plugins, function(p) {

diff --git a/src/JBrowse/GenomeView.js b/src/JBrowse/GenomeView.js
@@ -2309,6 +2309,10 @@ renderTrack: function( /**Object*/ trackConfig ) {
 
     // get the track class
     require( [ trackConfig.type ], function( class_ ) {
+        if(typeof class_ === "string") {
+            console.error("Failed to load module: "+trackConfig.type);
+            return;
+        }
         trackClass = class_;
         if( trackClass && store )
             makeTrack();

diff --git a/src/JBrowse/View/Track/CanvasFeatures.js b/src/JBrowse/View/Track/CanvasFeatures.js
@@ -324,6 +324,11 @@ return declare(
 
 
             require( [glyphClassName], function( GlyphClass ) {
+                         if( typeof GlyphClass == 'string' ) {
+                             thisB.fatalError = "could not load glyph "+glyphClassName;
+                             thisB.redraw();
+                             return;
+                         }
                          // if this require came back after we are already destroyed, just ignore it
                          if( thisB.destroyed )
                              return;