-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GPII-1987: Implement data loaders to load preferences and authorization test data into CouchDB #503
Conversation
…le.dataSource.URL because for creating and loading data into CouchDB, a pre-fetch feature provided by kettle.dataSource.CouchDB for checking on _revision value is not needed.
…tructure for CouchDB import.
…ns the actual implementation of the auth loader component and the other is to call the loader component to perform the loading so that the latter can be enhanced to accept an configuration.
…ting the error case.
… and error loading messages to the console.
… the GPII production VM to start properly.
CI job passed. |
CI job failed. Please visit http://lists.gpii.net/pipermail/ci/ for more details. |
ok to test |
CI job failed. Please visit http://lists.gpii.net/pipermail/ci/ for more details. |
ok to test |
CI job passed. |
When run on Windows. each test file still leaves several couchDB databases behind in /Temp, as well as the tests hanging in a characteristic way on attempted cleanup, although they do pass in the end: 02:48:01.927: Sending a GET request to: /auth on port 1234 |
CI job passed. |
… branch since avtar's pull request has been merged in.
CI job passed. |
@amb26, as per the discussion in the IRC channel today, @the-t-in-rtf has added a The Do you think README should be updated to include this explanation? |
@cindyli, the current wording in the README suggests using |
On a side note, I think we need to provide a means for running the browser tests in multiple browsers with a single command, and to include that command as part of In my own work I've used script definitions like:
Note that my example also includes code coverage for the node tests, which is also currently missing. If you both are in agreement, I'm happy to handle both in a small PR of my own against universal, as I'll be doing similar work in a few projects in the next week or so. |
@the-t-in-rtf, after the IRC discussion, please go ahead to issue the pull request for |
CI job passed. |
CI job passed. |
CI job passed. |
@amb26, this pull request has been updated to use the latest gpii-pouchdb release and ready for another review. |
@cindyli - I'm assuming this pull can be closed given the change in our requirements for data loading? |
Issue ticket: https://issues.gpii.net/browse/GPII-1987