Fix swapchain semaphore handling #424
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IAmNotHanni
commented
Jun 21, 2024
| @@ -2306,7 +2319,7 @@ static void DrawFrame() | |||
|
|
|||
| // Acquire swapchain image | |||
| uint32_t imageIndex = 0; | |||
| VkResult res = vkAcquireNextImageKHR(g_hDevice, g_hSwapchain, UINT64_MAX, g_hImageAvailableSemaphore, VK_NULL_HANDLE, &imageIndex); | |||
| VkResult res = vkAcquireNextImageKHR(g_hDevice, g_hSwapchain, UINT64_MAX, g_hImageAvailableSemaphores.at(g_SwapchainImageIndex), VK_NULL_HANDLE, &imageIndex); | |||
There was a problem hiding this comment.
Maybe a comment on this here: We can't do
uint32_t imageIndex = 0;
VkResult res = vkAcquireNextImageKHR(g_hDevice, g_hSwapchain, UINT64_MAX, g_hImageAvailableSemaphores.at(imageIndex), VK_NULL_HANDLE, &imageIndex);because imageIndex is written to by vkAcquireNextImageKHR (pass by reference), so we can't use is in the call directly. At the time of the function call, it would always be g_hImageAvailableSemaphores.at(0). I had to track the swapchain image index manually, as can be seen at the end of DrawFrame.
|
Thank you for this fix. |
adam-sawicki-a
added
bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #421
Please verify if this solution is technically correct.
Tested on NVIDIA RTX 3090, NVIDIA GeForce 940M, Intel Arc A770, and AMD Ryzen 9 7950X.
Have a nice weekend
Johannes