Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Falco #98

Closed
wants to merge 6 commits into from
Closed

Falco #98

wants to merge 6 commits into from

Conversation

FuhuXia
Copy link
Contributor

@FuhuXia FuhuXia commented May 10, 2022

For GSA/data.gov#3799

  1. Install falco helm chart with falcosidekick
  2. Add slack webhookurl. slack_webhookurl needs to be added to local file terraform.tfvars to have slack notification.

Custom Falco rule added for solr security but havn't figure out a way to apply it in the terraform code. remain in draft for now until coming back to fix it.

@FuhuXia FuhuXia marked this pull request as ready for review May 12, 2022 15:54
@FuhuXia FuhuXia requested a review from a team May 12, 2022 16:56
Copy link
Contributor

@nickumia-reisys nickumia-reisys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know we said that there isn't a good way of testing this (or at least a nice way of testing it). We should probably update the README to mention that Falco is installed and doing something.

Comment on lines +3 to +7
resource "kubernetes_namespace" "falco" {
metadata {
name = "falco"
}
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would suggest you annotate the namespace to help identify it better in terms of connecting to other resources, k8s relies a lot on annotations to know how to operate in different settings and environments. If we wanted to create a specific network policy for falco, the annotation would probably come in handy,
Example: https://github.com/GSA/datagov-brokerpak-eks/blob/main/terraform/modules/provision-k8s/k8s-network-policy.tf#L2-L9

name = "falco"
chart = "falco"
repository = "https://falcosecurity.github.io/charts"
version = "1.18.3"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this the latest version? Anything we should know about this version and compatibility with k8s version or other systems-specific versioning?

@nickumia-reisys
Copy link
Contributor

Also update the terraform.tfvars instructions on configuring the slack_webhookurl,

@FuhuXia FuhuXia marked this pull request as draft May 18, 2022 16:57
@btylerburton
Copy link

close this?

@FuhuXia FuhuXia closed this Jun 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants