-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Falco #98
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I know we said that there isn't a good way of testing this (or at least a nice way of testing it). We should probably update the README to mention that Falco is installed and doing something.
resource "kubernetes_namespace" "falco" { | ||
metadata { | ||
name = "falco" | ||
} | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would suggest you annotate the namespace to help identify it better in terms of connecting to other resources, k8s relies a lot on annotations to know how to operate in different settings and environments. If we wanted to create a specific network policy for falco, the annotation would probably come in handy,
Example: https://github.com/GSA/datagov-brokerpak-eks/blob/main/terraform/modules/provision-k8s/k8s-network-policy.tf#L2-L9
name = "falco" | ||
chart = "falco" | ||
repository = "https://falcosecurity.github.io/charts" | ||
version = "1.18.3" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this the latest version? Anything we should know about this version and compatibility with k8s version or other systems-specific versioning?
Also update the terraform.tfvars instructions on configuring the slack_webhookurl, |
close this? |
For GSA/data.gov#3799
slack_webhookurl
needs to be added to local fileterraform.tfvars
to have slack notification.Custom Falco rule added for solr security but havn't figure out a way to apply it in the terraform code. remain in draft for now until coming back to fix it.