Create render-ssp script #30
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* copy-profile also copies relevant ssp-render templates * keep control grouping in place for lato profile * Remove use of jinja template within implementation statements * Install trestle from gsa-tts fork
zjrgov
previously approved these changes
Sep 5, 2024
There was a problem hiding this comment.
This looks good to me! just some minor notes on a couple odd sentences and perceived spacing inconsistencies.
Each time I learn more about this process I am increasingly glad and excited for OSCAL and for having the production of these documents more automated.
Comment on lines
+22
to
+25
| Note: Make a copy of the table and populate for each external service | ||
| --> | ||
|
|
||
| Table 10-2. External Service |
There was a problem hiding this comment.
question (non-blocking): does each table get a title?
There was a problem hiding this comment.
Specifically for this section with "make a copy of the table..."? Answer unclear
Co-authored-by: Zachary Rollyson <zachary.rollyson@gsa.gov>
zjrgov
approved these changes
Sep 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎫 Addresses issue: #23
🛠 Summary of changes