Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Rails 7.2 support #113

Merged
merged 10 commits into from
Aug 27, 2024
Merged

Add Rails 7.2 support #113

merged 10 commits into from
Aug 27, 2024

Conversation

rahearn
Copy link
Contributor

@rahearn rahearn commented Aug 21, 2024

Changes:

  • Generate rails 7.2 apps.
  • general gem version updates
  • add a dependabot config to the github actions generator
  • small fix to bin/trestle and bin/auditree to pass CLI args into docker

closes #109

@rahearn rahearn requested review from beechnut and a team August 21, 2024 18:29
@rahearn rahearn marked this pull request as draft August 22, 2024 14:19
@rahearn
Copy link
Contributor Author

rahearn commented Aug 22, 2024

Converting to draft as the update command needs more work.

Copy link
Member

@beechnut beechnut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I ran it, I have a project, and I ran rails c and rails s with the expected results.

However, the end of the log exited with a non-zero exit code? Not sure what's going on there.

# ... log log log ...
create mode 100644 zap.conf
         run  git add . from "."
         run  git commit -a -m 'Initial commit' from "."
On branch main
nothing to commit, working tree clean
⚠️   1   # <-- the non-zero exit

Otherwise, just left a couple suggested changes for the readme.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

change (non-blocking): Even though I think I was the person who wrote the readme, I was confused trying to follow it! The commands are nested inside numbers, then bullets, then sub-bullets, then parentheses. I

change: It asked me about docker-trestle and compliance-as-code and I had no idea what to select and the readme doesn't explain it. Could you add something about that to guide a decision?

@rahearn
Copy link
Contributor Author

rahearn commented Aug 22, 2024

However, the end of the log exited with a non-zero exit code? Not sure what's going on there.

I'm 99% certain that's from the git commit resulting in "nothing to commit, working tree clean". Which is itself surprising, unless you ran it multiple times with the same destination directory?

@beechnut
Copy link
Member

beechnut commented Aug 22, 2024

EDIT: Yep, that's it!

<details><summary>If you are using Hotwire, run:</summary>

```
$ rails_template_18f new <project name> --hotwire ADDITIONAL_CONFIG_OPTIONS
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't love ADDITIONAL_CONFIG_OPTIONS but couldn't think of a better way to say "insert any --no-skip... options here"

@rahearn rahearn marked this pull request as ready for review August 22, 2024 18:44
@rahearn rahearn requested a review from beechnut August 22, 2024 18:44
Copy link
Contributor

@pauldoomgov pauldoomgov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for addressing the feedback! Approved!

@rahearn rahearn merged commit 1ee9028 into main Aug 27, 2024
3 checks passed
@rahearn rahearn deleted the rails-7.2 branch August 27, 2024 18:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rails 7.2 support
3 participants