-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Rails 7.2 support #113
Conversation
Converting to draft as the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I ran it, I have a project, and I ran rails c
and rails s
with the expected results.
However, the end of the log exited with a non-zero exit code? Not sure what's going on there.
# ... log log log ...
create mode 100644 zap.conf
run git add . from "."
run git commit -a -m 'Initial commit' from "."
On branch main
nothing to commit, working tree clean
⚠️ 1 # <-- the non-zero exit
Otherwise, just left a couple suggested changes for the readme.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
change (non-blocking): Even though I think I was the person who wrote the readme, I was confused trying to follow it! The commands are nested inside numbers, then bullets, then sub-bullets, then parentheses. I
change: It asked me about docker-trestle and compliance-as-code and I had no idea what to select and the readme doesn't explain it. Could you add something about that to guide a decision?
I'm 99% certain that's from the |
EDIT: Yep, that's it! |
<details><summary>If you are using Hotwire, run:</summary> | ||
|
||
``` | ||
$ rails_template_18f new <project name> --hotwire ADDITIONAL_CONFIG_OPTIONS |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't love ADDITIONAL_CONFIG_OPTIONS
but couldn't think of a better way to say "insert any --no-skip... options here"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for addressing the feedback! Approved!
Changes:
bin/trestle
andbin/auditree
to pass CLI args into dockercloses #109