Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new: turn off all harvesting + only test on relevant file changes #465

Merged
merged 2 commits into from
Jun 6, 2022

Conversation

nickumia-reisys
Copy link
Contributor

@nickumia-reisys nickumia-reisys commented Jun 6, 2022

Related to GSA/data.gov#3826

This is primarily to switch from solr on eks to solr on ecs; however, trying to only run tests on relevant file changes

New Github Action dependency:

This is primarily to switch from solr on eks to solr on ecs; however, trying to only run tests on relevant file changes
The other way would have worked if the job wasn't required.  I like this solution... I think
@nickumia-reisys nickumia-reisys requested review from jbrown-xentity, FuhuXia and a team June 6, 2022 18:57
Copy link
Contributor

@jbrown-xentity jbrown-xentity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, although we could probably be even more explicit in what we test and what we don't. I think this is fine though!

Comment on lines +26 to +27
configure-postgis.py
configure-postgis.sql
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pretty sure these are only run in cloud.gov, no need to run tests here.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought they were run with the local docker environment to set up the database. But I know we barely (if ever) change these files, so it's all good 😆

@nickumia-reisys nickumia-reisys merged commit cc087ee into main Jun 6, 2022
@nickumia-reisys nickumia-reisys deleted the turn-off-harvesting branch June 6, 2022 19:26
@nickumia-reisys nickumia-reisys changed the title new: turn off all harvesting new: turn off all harvesting + only test on relevant file changes Jun 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants