-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update search.html #211
Update search.html #211
Conversation
I do like the way this looks, thanks! Reflecting on it with fresh eyes, I am not sure my text is the best choice. using "search operators" may be confusing. I will think about plain language text here, but the styling is nice, thanks! |
|
Good catch, @FuhuXia. It just disappears eh? Maybe I don't know enough front-end to have picked up this ticket 😕 |
No. the screenshot I took is from prod, not from the changed theme. I just want to make sure the new text you added looks ok with other UI elements in terms of spacing and styling. We can deploy your change to catalog-dev to see how it looks like with other UI elements. |
I tested locally against the other error message to: "Please try another search.", which appears when you get no results, and it looked fine, but definitely worth testing that case as well. I can't recall if I did. |
@tdlowden what's the status on this? you need any help from dev team to get it up on a test environment? |
Yes, we kind of punted until we could get it up on dev to make sure it all worked well. The dev got screwy for a bit. I think we should try to push this to dev and QA |
fca42dc
to
8f7e986
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If this looks good in the UI, let's go for it!
I don't like the way this appears. Need some CSS help to get it across the finish line.
Addresses GSA/data.gov#4697