Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set max_resource_count #158

Merged
merged 5 commits into from
Sep 25, 2024
Merged

Set max_resource_count #158

merged 5 commits into from
Sep 25, 2024

Conversation

FuhuXia
Copy link
Member

@FuhuXia FuhuXia commented Sep 24, 2024

For GSA/data.gov#4902

If ckanext.datajson.max_resource_count is set, records with resources more then the count will see import errors, harvest job will move on, not getting stuck.

@FuhuXia FuhuXia requested a review from a team September 24, 2024 22:06
Copy link

@jbrown-xentity jbrown-xentity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, nice test!
What should the limit be at the catalog level? And should we send out a message to data providers before/when we release this?

@FuhuXia
Copy link
Member Author

FuhuXia commented Sep 25, 2024

1000 is a good starting point. it is verified in the development space.

@FuhuXia FuhuXia merged commit fe4ccb6 into main Sep 25, 2024
3 checks passed
@FuhuXia FuhuXia deleted the max-resource branch September 25, 2024 13:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants