Skip to content
This repository has been archived by the owner on Mar 5, 2024. It is now read-only.

Configures LocalExecutor using Python Buildpack #3

Merged
merged 8 commits into from
Nov 21, 2023
Merged

Configures LocalExecutor using Python Buildpack #3

merged 8 commits into from
Nov 21, 2023

Conversation

btylerburton
Copy link
Collaborator

@btylerburton btylerburton commented Nov 16, 2023 •
edited
Loading

@btylerburton btylerburton mentioned this pull request Nov 16, 2023
Closed
3 tasks
@btylerburton
working version of airflow standalone pushed to cloud.gov development…
0f53a47 
… space
@btylerburton
working implementation; all excess files cleaned; TODO: update README
279b4b2
@btylerburton
adds working buildpak manifest and docker compose with celery
7bdfab4
@btylerburton
Updates python version to match pip install;
7326517 
adds single property to airflow.cfg to confirm its being honeored;
deletes old Dockerfiles from Docker image effort;
adds some convenient lifecycle commands to Makefile;
removes single prop from manfiest env vars and ports to airflow.cfg;
updates etl_pipeline dag with "daily" tag;
adds static test dag
@btylerburton
adds new README and WIP version of devcontainer.json
57cff4e
@btylerburton
remove old readme
1c02d1c
@btylerburton btylerburton force-pushed the configure-local-executor__buildpak branch from 7226029 to 1c02d1c Compare November 17, 2023 00:16
@btylerburton btylerburton marked this pull request as ready for review November 17, 2023 00:22
@btylerburton btylerburton requested a review from a team November 17, 2023 00:22
@btylerburton btylerburton mentioned this pull request Nov 17, 2023
Closed
6 tasks
jbrown-xentity
jbrown-xentity previously approved these changes Nov 17, 2023
View reviewed changes
Copy link
Contributor

@jbrown-xentity jbrown-xentity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, though local dev and cloud.gov dev don't match (local docker uses celery)

docker-compose.yml Outdated Show resolved Hide resolved
@btylerburton
Copy link
Collaborator Author

Based on what we've seen with the LocalExecutor, its almost certain that we want to push forward with Celery, but it does make sense to mirror local w/ remote, so I will make a default docker-compose using LocalExecutor and then include the other Celery docker setup as well.

@btylerburton
Copy link
Collaborator Author

Just added a new docker-compose running LocalExecutor. We should be good to go here.

@btylerburton btylerburton requested a review from a team November 21, 2023 15:40
@robert-bryson robert-bryson merged commit 14c633f into main Nov 21, 2023
@btylerburton btylerburton deleted the configure-local-executor__buildpak branch November 21, 2023 17:38
This was referenced Nov 29, 2023
Closed
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@robert-bryson robert-bryson robert-bryson approved these changes

@jbrown-xentity jbrown-xentity jbrown-xentity left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@btylerburton @jbrown-xentity @robert-bryson