Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updated to jekyll 3.9.2 partially resolving issue (#313) #314

Merged
merged 2 commits into from
Jun 8, 2022

Conversation

nick-mon1
Copy link
Contributor

@nick-mon1 nick-mon1 commented Jun 7, 2022

WIP, currently blocked at jekyll 3.9.2.

Resolves issue #313

  • Update to Jekyll 4.2.2
  • Use ruby >= 2.4.0
  • Update bundler
  • Update bundler dependencies

Jekyll is blocked with the following gem dependencies:

Bundler could not find compatible versions for gem "jekyll":
In Gemfile:
jekyll (~> 4.2.2)

jekyll_pages_api_search was resolved to 0.5.0, which depends on
  jekyll_pages_api (~> 0.1.4) was resolved to 0.1.6, which depends on
    jekyll (>= 2.0, < 4.0)

May need to consider replacing jekyll_pages_api with another gem.

@nick-mon1 nick-mon1 requested a review from mejiaj June 7, 2022 14:39
@nick-mon1 nick-mon1 self-assigned this Jun 7, 2022
@nick-mon1
Copy link
Contributor Author

nick-mon1 commented Jun 7, 2022

We can update to jekyll 4.2.2 but will have to drop the current jekyll_pages_api_search gem because it does not support jekyll 4

Implementing search.gov search service will require some additional effort, this would be a multi-step process and some coordination with the search.gov team to integrate with the site. Additional testing will be required to make sure the search results page looks good and performs as expected.

In the meantime we can update to jekyll 3.9.2 and still use the current search features until we decide to complete the search.gov integration.

Copy link
Contributor

@mejiaj mejiaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good so far, just a few things. A question about commented line regarding jekyll version.

Could we also look into updating .bundler-version? The last update was 3 years ago.

Gemfile Outdated Show resolved Hide resolved
@nick-mon1
Copy link
Contributor Author

I've updated to bundler 2.3.15, the most current version.

@mejiaj mejiaj merged commit e059adb into master Jun 8, 2022
@mejiaj mejiaj deleted the nl-update-jekyll-dependencies branch June 8, 2022 17:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants