Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

setuptools>=70.0.0 #750

Merged
merged 2 commits into from
Jul 18, 2024
Merged

setuptools>=70.0.0 #750

merged 2 commits into from
Jul 18, 2024

Conversation

FuhuXia
Copy link
Member

@FuhuXia FuhuXia commented Jul 16, 2024

synk found vulnerability in setuptools prior to 70.0.0

@FuhuXia FuhuXia requested a review from a team July 16, 2024 16:57
@jbrown-xentity
Copy link
Contributor

Snyk still thinks it's vulnerable, even though it's explicitly using a fixed version... That's weird. I think we can mark it successful, but snyk may continue to report it.

@FuhuXia
Copy link
Member Author

FuhuXia commented Jul 17, 2024

The synk test command run on local is passing. Maybe we should use that for PR checks.
The security/snyk check is supposed to be used as a daily task checking main branch, not meant for PR check?

@btylerburton
Copy link
Contributor

btylerburton commented Jul 17, 2024

Maybe we should use that for PR checks.

I've had my share of fights with Snyk CI lately not registering changes. Seems like it might be more reliable to use the local lib.

@FuhuXia FuhuXia merged commit 84d459a into main Jul 18, 2024
5 of 6 checks passed
@FuhuXia FuhuXia deleted the setuptools-70 branch July 18, 2024 13:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants