Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Variable condition restrictions #1956

Open
2 tasks
em-herrick opened this issue Sep 23, 2024 · 2 comments
Open
2 tasks

Variable condition restrictions #1956

em-herrick opened this issue Sep 23, 2024 · 2 comments
Assignees
Labels

Comments

@em-herrick
Copy link
Contributor

em-herrick commented Sep 23, 2024

Issue

Oregon is hoping to send messages using variable information in one-off sends: ((insert local office phone number)).
They would like to use variable data to indicate a needed local office phone number, and have each sender fill in the right phone number as part of the one-off sending process.

We found, that including the words "phone", "number", and "contact" as variable data confuses Notify and causes messages to be sent with this template to fail. See video:

Screen.Recording.2024-09-23.at.10.27.30.AM.mov

To reproduce:

  1. Create a new template
  2. Use this template text:

Hello, this is ((insert your name)) from ODHS. I will be giving you a call in the next five minutes from 1-503-945-5722 to talk about your recent request for benefits. If you would like to verify this message, please contact us at ((insert local office phone number)).

  1. Observe that the last variable is not highlighed yellow
  2. Use template
  3. Send to your self / one phone number
  4. Insert your first name
  5. insert 1-888-999-0000 as second variable
  6. observe the fail

Desired State:

  • Allow some version of "phone" or "number" or "contact" to be included as variable information OR if this is not possible
  • retrieve a list of all words that CANNOT be used as variable information and include this list as help content near template
@em-herrick em-herrick converted this from a draft issue Sep 23, 2024
@em-herrick em-herrick added the bug label Sep 23, 2024
@terrazoon terrazoon self-assigned this Sep 24, 2024
@terrazoon terrazoon moved this from ⬇ Up-Next to 🏗 In progress (WIP: ≤ 3 per person) in Notify.gov product board Sep 24, 2024
@em-herrick
Copy link
Contributor Author

Fix—
exact match for "phone number" is not allowed. "insert phone number" is okay.

"contact" is still an unknown issue

@terrazoon terrazoon moved this from 🏗 In progress (WIP: ≤ 3 per person) to 👀 In review in Notify.gov product board Sep 27, 2024
@terrazoon
Copy link
Contributor

@terrazoon terrazoon moved this from 👀 In review to ✅ Done in Notify.gov product board Sep 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Archived in project
Development

No branches or pull requests

2 participants