Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix phone number lookup #1336

Merged
merged 2 commits into from
Sep 27, 2024
Merged

fix phone number lookup #1336

merged 2 commits into from
Sep 27, 2024

Conversation

terrazoon
Copy link
Contributor

@terrazoon terrazoon commented Sep 24, 2024

Description

Our previous method of extracting phone numbers from S3 files was too simplistic, since users might include the words "phone number" in custom placeholders. See notify-admin #1956

Security Considerations

N/A

@terrazoon terrazoon self-assigned this Sep 24, 2024
Copy link
Contributor

@ccostino ccostino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @terrazoon!

Copy link
Member

@A-Shumway42 A-Shumway42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@terrazoon terrazoon merged commit b265186 into main Sep 27, 2024
7 checks passed
@terrazoon terrazoon deleted the notify-admin-1956 branch September 27, 2024 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants