Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update name of Redis to include v70 #1119

Merged
merged 1 commit into from
Jun 26, 2024

Conversation

jskinne3
Copy link
Contributor

Changes the name of the Redis instance we are using to an updated name corresponding to a version upgrade. This will unbind the old version and bind the new. This applies to all environments, because they share a single manifest file.

We think this will work without manually using the cf unbind-service and cf bind-service commands.

I considered undoing PR #1116 because it is a step that should occur after this one. But it appears the deployment pipeline is refusing to apply that PR while the old Redis is still bound, and thus, undoing it in source control is not necessary. It should take effect after this one.

@jskinne3 jskinne3 requested review from ccostino, stvnrlly and a team June 26, 2024 18:17
Copy link
Contributor

@xlorepdarkhelm xlorepdarkhelm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. It looks like this is all that is needed.

Copy link
Contributor

@ccostino ccostino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @jskinne3!

@ccostino ccostino merged commit 6dd27a0 into main Jun 26, 2024
7 checks passed
@ccostino ccostino deleted the jskinne3-manifest-update-redis-name branch June 26, 2024 18:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants