-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
write command to download csv file #1196
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @terrazoon for attempting to make the debugging easier here for folks!
Unfortunately, we can't move forward with this as is, because by exposing the phone numbers/emails in the logs, we run the risk of them being exposed in addition to violating the very principles on safeguarding this data that we've outlined in our SSPP and reviewed with our assessors to meet a variety of NIST controls about PII.
Since this is within the command that would download the file anyway, what were you hoping to achieve or help with by having the contents of the file itself put in the logs, other than the tedium?
yeah, brain problems. I changed it. |
@ccostino I changed it again. Now using the s3.download_file() functionality from both 3. I had to unship a random test also to keep coverage at 95% |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great, thanks @terrazoon! This looks like it's ready to go now; we ought to be able to test it in staging to be sure!
Description
The developer can get the s3 file location for a problematic csv file from the admin logs. Write a command so the developer can download the csv file contents securely.
Security Considerations
N/A