Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make user command #1206

Merged
merged 5 commits into from
Aug 9, 2024
Merged

make user command #1206

merged 5 commits into from
Aug 9, 2024

Conversation

terrazoon
Copy link
Contributor

@terrazoon terrazoon commented Jul 23, 2024

Description

To improve logging of the sign-in flow without revealing PII, we need to obtain the user_id from production. So, write a command that takes a user's email address and dumps user info to the platform admin's terminal.

Security Considerations

We are dumping info that contains PII to the the platform admin's terminal.

Copy link
Contributor

@xlorepdarkhelm xlorepdarkhelm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ccostino
Copy link
Contributor

ccostino commented Aug 5, 2024

Hopefully another merge with main fixes the test coverage amount again!

Copy link
Contributor

@xlorepdarkhelm xlorepdarkhelm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@ccostino ccostino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @terrazoon!

@ccostino ccostino merged commit f501b82 into main Aug 9, 2024
7 checks passed
@ccostino ccostino deleted the notify-admin-1505 branch August 9, 2024 19:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants