Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve exponential backoff while job hunting #1277

Merged
merged 7 commits into from
Aug 16, 2024
Merged

improve exponential backoff while job hunting #1277

merged 7 commits into from
Aug 16, 2024

Conversation

terrazoon
Copy link
Contributor

@terrazoon terrazoon commented Aug 16, 2024

Description

  1. Shorten exponential back-off times so that we don't time out just because we're doing back offs
  2. Do an initial check to see if it even looks like the job is in the bucket before we start any back offs
  3. Use global variable/singleton so we aren't endless recreating boto resources.

Security Considerations

N/A

@terrazoon terrazoon marked this pull request as draft August 16, 2024 16:53
@terrazoon terrazoon changed the title initial improve exponential backoff while job hunting Aug 16, 2024
@terrazoon terrazoon marked this pull request as ready for review August 16, 2024 19:32
@terrazoon terrazoon self-assigned this Aug 16, 2024
Copy link
Contributor

@ccostino ccostino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @terrazoon!

I'm not quite sure how I feel about the global but I do see what you're doing with reusing resources and such, and saw the commented out line in the test too. For the sake of trying to nail this down since it's an active production issue, I'm good to go with this as it is though. 🙂

Copy link
Member

@A-Shumway42 A-Shumway42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Fingers crossed!

@terrazoon terrazoon merged commit 9182ba0 into main Aug 16, 2024
7 checks passed
@terrazoon terrazoon deleted the more_backoff branch August 16, 2024 19:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants