fix log formatting #1289
Merged
fix log formatting #1289
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We do some log formatting to prettify the logs, which is great, but the formatting fails if the log message is a nested dictionary, which it is when we get delivery receipts from AWS. Which means we are getting a stack trace every time a message is delivered or permanently fails. This serves no purpose, and doesn't affect logging at all (ie, we still get the delivered/failed message, just with extra unwanted stack traces).
Suppress the stack trace if it is caused by a KeyError.
Security Considerations
N/A