Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

make it possible to write secrets #1292

Merged
merged 1 commit into from
Aug 22, 2024
Merged

make it possible to write secrets #1292

merged 1 commit into from
Aug 22, 2024

Conversation

terrazoon
Copy link
Contributor

Description

deploy script was read only. Change that.

Security Considerations

N/A

@terrazoon terrazoon self-assigned this Aug 22, 2024
xlorepdarkhelm
xlorepdarkhelm approved these changes Aug 22, 2024
View reviewed changes
Copy link
Contributor

@xlorepdarkhelm xlorepdarkhelm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

ccostino
ccostino approved these changes Aug 22, 2024
View reviewed changes
Copy link
Contributor

@ccostino ccostino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @terrazoon!

@ccostino ccostino merged commit 916ba67 into main Aug 22, 2024
7 checks passed
@ccostino ccostino deleted the notify-api-144 branch August 22, 2024 21:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xlorepdarkhelm xlorepdarkhelm xlorepdarkhelm approved these changes

@ccostino ccostino ccostino approved these changes

Assignees

@terrazoon terrazoon

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@terrazoon @ccostino @xlorepdarkhelm