Added new ADR for BackstopJS #1297
Conversation
There was a problem hiding this comment.
Awesome, thanks @alexjanousekGSA!
This looks good to me aside from one minor grammatical change. I'll give folks a bit of time to weigh in as well. 🙂
ccostino
requested review from
xlorepdarkhelm,
jonathanbobel,
ecayer,
stvnrlly,
terrazoon,
heyitsmebev and
A-Shumway42
Co-authored-by: Carlo Costino <ccostino@users.noreply.github.com>
alexjanousekGSA
temporarily deployed
to
staging
GitHub Actions
Inactive
There was a problem hiding this comment.
Thanks @alexjanousekGSA for solutions to testing! I don't have any questions about BackstopJS for now. I am curious by the potential of BackstopJS. I'd like to see BackstopJS as an option for testing until we become more familiar with it and understand its use cases better. We already have many different testing tools on the frontend, and while BackstopJS is not exactly the same, managing and testing with multiple tools can be cumbersome.
That said, I'm curious about the tool and do think it could be helpful to see at a glance which parts of the site have changed. This could be particularly useful if an image goes missing unexpectedly or if there are CSS or layout changes. I'm open to exploring the value and insights it could provide.
It would be helpful to run it quickly, similar to how we use flake8 or isort, but overall, I think we should keep it optional for now.
There was a problem hiding this comment.
Thanks for writing this up, @alexjanousekGSA! 🎉
Once this is merged, we're going to make a few adjustments and additions to it, and flip it to the accepted state.
ADR outlining proposal for adding backstop JS to admin project to improve QA.
Original Issue including screenshots done during testing can be found here
Details around the deep dive and POC can be found here