E2E Test Improvement: leverage the live staging API instead of deploying a local instance in CI/C #1316
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Unraveling what exactly is going on with the auth token on the admin side (doesn't match API side) seems rather involved and may ultimately require that we bring all of notifications-python-client package into our code base, something we'd hoped to avoid. In the meantime, try to see if we can get e2e tests working by relaxing auth checks on staging tier.
Security Considerations
Bypassing auth check on staging tier should be fine, but need to be mindful to never ever allow for all tiers.