Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix load test #1338

Merged
merged 1 commit into from
Sep 25, 2024
Merged

fix load test #1338

merged 1 commit into from
Sep 25, 2024

Conversation

terrazoon
Copy link
Contributor

@terrazoon terrazoon commented Sep 25, 2024

Description

We are doing experimental work to validate phone numbers with pinpoint, and right now that validation is limited to AWS simulated numbers only. Unfortunately, we are also using the AWS simulated numbers for the load test, so load test on staging is broken due to the problems with pinpoint phone validation.

Add a check to make sure we are on the development or test tiers before doing phone number validation.

Security Considerations

N/A

Copy link
Contributor

@ccostino ccostino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @terrazoon

Copy link
Member

@A-Shumway42 A-Shumway42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! Looks good!

@terrazoon terrazoon merged commit 9cd1b8d into main Sep 25, 2024
7 checks passed
@terrazoon terrazoon deleted the argh_load_test branch September 25, 2024 18:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants