fix personalization_bug for one-offs #1349
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ccostino
approved these changes
Oct 1, 2024
There was a problem hiding this comment.
Thanks, @terrazoon!
Noting here that there is an issue for the test coverage: #1342
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Some of the work we did for using shared memory and concurrent downloads managed to break personalizations, so fix that here.
Also, stop running coverage on test code. This means our true level of coverage is 91%. Temporarily set it to 91% and make a ticket to bring coverage up to 95% ASAP.
NOTE: I made changes to the tests, then I reverted them. I'm not sure why the formatting looks like that and there is a big diff, but the actual code didn't change.
Security Considerations
N/A