Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: Invites expiring immediately #1354

Merged
merged 1 commit into from
Oct 3, 2024
Merged

Bug: Invites expiring immediately #1354

merged 1 commit into from
Oct 3, 2024

Conversation

terrazoon
Copy link
Contributor

Description

We have to temporarily park some info related to the invite in redis, and I think due to an excess of security thinking, a 30 minute timeout was applied to that info. But users actually have a whole day to accept the invite. So I think this bug has been here for a while and we just didn't have any people who dawdled in accepting their invites. Change the timeout to two days for redis.

Security Considerations

N/A

@terrazoon terrazoon self-assigned this Oct 2, 2024
Copy link
Contributor

@ccostino ccostino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah nice catch, thanks @terrazoon!

@ccostino ccostino merged commit e6cf8a9 into main Oct 3, 2024
7 checks passed
@ccostino ccostino deleted the notify-admin-1976 branch October 3, 2024 18:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants