Update egress proxy deployment steps #1358
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This changeset updates the egress proxy deployment steps to match the admin repo, based on lessons learned there. Signed-off-by: Carlo Costino <carlo.costino@gsa.gov>
ccostino
added
engineering
github_actions
ccostino
requested review from
jonathanbobel,
stvnrlly,
terrazoon,
heyitsmebev,
A-Shumway42 and
alexjanousekGSA
terrazoon
approved these changes
Oct 7, 2024
Signed-off-by: Carlo Costino <carlo.costino@gsa.gov>
Signed-off-by: Carlo Costino <carlo.costino@gsa.gov>
Signed-off-by: Carlo Costino <carlo.costino@gsa.gov>
A-Shumway42
approved these changes
Oct 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A note to PR reviewers: it may be helpful to review our code review documentation to know what to keep in mind while reviewing pull requests.
Description
This changeset updates the egress proxy deployment steps to match the admin repo, based on lessons learned there.
NOTE: Once we get this working, we'll have to uncomment the check for repo changes, as we don't need to deploy this every single time.
Security Considerations