Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrade test queries to sqlalchemy 2.0 #1382

Merged
merged 28 commits into from
Nov 13, 2024
Merged

upgrade test queries to sqlalchemy 2.0 #1382

merged 28 commits into from
Nov 13, 2024

Conversation

terrazoon
Copy link
Contributor

@terrazoon terrazoon commented Oct 30, 2024

Description

Fix some of the remaining sqlalchemy 1.4 implementations in queries. I'm using this to count:

grep -ri "query." | wc -l

and it currently gives a count of 307. I think at least 50 of that is false positives, but still there is more work to be done. However this PR is quite big so might as well get it checked in.

Security Considerations

N/A

@terrazoon terrazoon marked this pull request as draft October 30, 2024 14:59
@terrazoon terrazoon self-assigned this Oct 30, 2024
@terrazoon terrazoon marked this pull request as ready for review October 31, 2024 21:45
Copy link
Member

@A-Shumway42 A-Shumway42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There was an issue with .scalars() last week and it returning a single column when we needed the complete results (but there wasn't test coverage for that code so it wasn't caught). I see .scalars() being used here but they all look appropriate.
LGTM!

@terrazoon terrazoon merged commit 0485297 into main Nov 13, 2024
7 checks passed
@terrazoon terrazoon deleted the notify-api-1325 branch November 13, 2024 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants