Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

12/2/24 - 12/3/24 Production Deploy - DB insert retry and go live email fixes #1451

Merged
merged 15 commits into from
Dec 3, 2024

Conversation

ccostino
Copy link
Contributor

@ccostino ccostino commented Dec 2, 2024

A note to PR reviewers: it may be helpful to review our code review documentation to know what to keep in mind while reviewing pull requests.*

Description

This production deploy contains two small but important fixes:

  • An adjustment to the DB insertion and retry logic for capturing message information
  • A fix for sending out emails that a service has been turned live

Security Considerations

  • Both of these fixes will help improve application stability and reduce the amount of errors thrown.

@ccostino ccostino added engineering python Pull requests that update Python code labels Dec 2, 2024
@ccostino ccostino self-assigned this Dec 2, 2024
Copy link
Contributor

@terrazoon terrazoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I note that the email retry time period changed from 300 seconds to 30 seconds, which was originally a change for debugging. However, I don't think it matters since the purpose of 300 seconds was to check for delivery receipts in AWS, and we don't do that for emails.

@ccostino ccostino merged commit 480357d into production Dec 3, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
engineering python Pull requests that update Python code
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

5 participants