Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

start writing message ids to the notifications table #1485

Merged
merged 9 commits into from
Dec 13, 2024
Merged

Conversation

terrazoon
Copy link
Contributor

@terrazoon terrazoon commented Dec 13, 2024

Description

Start writing message_ids to the new message_id column in the notifications table.

I verified locally this writes message_ids to the notification table. We'll use the message_ids to map delivery receipts to notifications.

Security Considerations

N/A

Copy link
Contributor

@ccostino ccostino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @terrazoon! One quick question but not a hold up.

app/celery/provider_tasks.py Show resolved Hide resolved
@terrazoon terrazoon merged commit 3127e71 into main Dec 13, 2024
7 checks passed
@terrazoon terrazoon deleted the notify-api-1465 branch December 13, 2024 21:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants