notify-api-390 use moto to mock text sending. #448
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ccostino
requested changes
Sep 21, 2023
There was a problem hiding this comment.
Awesome, thank you @terrazoon!
There's just one piece here that needs to be addressed: Pipfile.lock got re-added somehow. That just needs to be removed and you can just delete it locally too to make sure it doesn't appear again. :-)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I will write a separate ticket for getting CloudWatch Logs to work. I'm thinking to add awslocal to our dependencies and then write a script (which people will have to run as part of the setup process, etc.)