Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doc updates for logs and env vars #481

Merged
merged 8 commits into from
Sep 23, 2023
Merged

Doc updates for logs and env vars #481

merged 8 commits into from
Sep 23, 2023

Conversation

stvnrlly
Copy link
Collaborator

@stvnrlly stvnrlly commented Sep 18, 2023

Closes #380

This adds some documentation about two areas:

  • Log locations and how to navigate Kibana
  • The several places where env vars live in order to work properly

@stvnrlly stvnrlly marked this pull request as draft September 21, 2023 14:12
@ccostino
Copy link
Contributor

@stvnrlly just flag me whenever this is ready - I know we talked about adding a couple of things, if you need me to work on anything directly just let me know as well. Thanks!

@stvnrlly stvnrlly temporarily deployed to staging September 21, 2023 17:28 — with GitHub Actions Inactive
@stvnrlly stvnrlly temporarily deployed to staging September 22, 2023 20:07 — with GitHub Actions Inactive
@stvnrlly stvnrlly marked this pull request as ready for review September 22, 2023 20:08
@stvnrlly stvnrlly requested a review from ccostino September 22, 2023 20:08
@stvnrlly stvnrlly temporarily deployed to staging September 22, 2023 20:24 — with GitHub Actions Inactive
Copy link
Contributor

@ccostino ccostino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @stvnrlly!

I added a couple of small suggestions but they're not showstoppers; accept/reject as you see fit and go forth!

docs/all.md Outdated Show resolved Hide resolved
docs/all.md Outdated Show resolved Hide resolved
docs/all.md Outdated Show resolved Hide resolved
Co-authored-by: Carlo Costino <ccostino@users.noreply.github.com>
@stvnrlly stvnrlly temporarily deployed to staging September 23, 2023 01:59 — with GitHub Actions Inactive
Co-authored-by: Carlo Costino <ccostino@users.noreply.github.com>
@stvnrlly stvnrlly temporarily deployed to staging September 23, 2023 01:59 — with GitHub Actions Inactive
Co-authored-by: Carlo Costino <ccostino@users.noreply.github.com>
@stvnrlly stvnrlly temporarily deployed to staging September 23, 2023 01:59 — with GitHub Actions Inactive
@stvnrlly stvnrlly merged commit 9eb7c92 into main Sep 23, 2023
@stvnrlly stvnrlly deleted the stvnrlly/docs-91823 branch September 23, 2023 02:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add "Where to get logs" in the documentation
2 participants