-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Api 414 set up enums #745
Api 414 set up enums #745
Conversation
5124ecc
to
22ab1be
Compare
7e1da5f
to
e3f9097
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Whew, there is a lot here @xlorepdarkhelm, thank you!
After doing a preliminary review of it all, I had a few questions as I went through for clarification, and noted a few spots that we'll need to pay close attention to in the future (webauthn
, priority queue, letter processing, and one or two other things).
I also flagged spots that were caught up in the mix that have fake test data like bogus email and phone numbers that we'll want to probably change too to make sure we're clear of any potential testing snafus in the future.
Overall this looks great so far, thanks for taking the time to work through all of this! On to figuring out what's up with the tests...
Signed-off-by: Cliff Hill <Clifford.hill@gsa.gov>
Signed-off-by: Cliff Hill <Clifford.hill@gsa.gov>
Signed-off-by: Cliff Hill <Clifford.hill@gsa.gov>
Signed-off-by: Cliff Hill <Clifford.hill@gsa.gov>
Signed-off-by: Cliff Hill <Clifford.hill@gsa.gov>
Signed-off-by: Cliff Hill <Clifford.hill@gsa.gov>
Signed-off-by: Cliff Hill <Clifford.hill@gsa.gov>
83f76d4
to
5bab443
Compare
Signed-off-by: Cliff Hill <Clifford.hill@gsa.gov>
Signed-off-by: Cliff Hill <Clifford.hill@gsa.gov>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I left a couple questions, mostly just out of curiosity. There is one place where the permissions expected in a test change kind of randomly, but I assume there's a reason for it. Everything else seems to be in order.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, @xlorepdarkhelm, lots of good stuff here!
I've finished a second pass through and had a few more questions and wanted to double check some things, but nothing major stands out, nicely done!
I'll run through and test locally as well while you and others are following up here. :-)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tested all of the following:
- log in
- send a message
- create a template
- copy a template
- view a dashboard
- download a report
- send an invite
- create a service
- update service settings
- click anything else you feel like - poked around various other spots on the site and repeated several actions in multiple services
- sign out
And everything is working fine, nor did I see any errors show up in the logs (none that weren't my own doing anyway 😆). Awesome work @xlorepdarkhelm, thank you!
This represents the first in a massive cleanup effort for models.py. Simply: Changing all of the "constant" strings defined in models.py into enums in enums.py, and update all references to them.
SMS_TYPE
andEMAIL_TYPE
), so these were checked on a case-by-case basis.This is a very large PR. Because these strings were, well, everywhere. But it helps with the cleanup of models.py to help organize how such things are implemented, standardizing them, and pulling the enums out of the file completely.
Issue: #414
Note: Do not close this issue when the PR is merged, as the issue will not be completed. This is only part 1.