Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

If phone number is unavailable, change text to 'Unavailable' #814

Merged
merged 2 commits into from
Feb 27, 2024

Conversation

terrazoon
Copy link
Contributor

@terrazoon terrazoon commented Feb 23, 2024

Description

Previously we were showing a long error message if we knew the CSV file blew up, otherwise if we could not get the phone number we showed 'Unknown Phone'. Standardize on 'Unavailable'.

Security Considerations

N/A

@terrazoon terrazoon self-assigned this Feb 23, 2024
@terrazoon terrazoon changed the title Notify api 809 If phone number is unavailable, change text to 'Unavailable' Feb 23, 2024
@ccostino
Copy link
Contributor

ccostino commented Feb 23, 2024

Weird that the notifications-python-client version bump is still in here when that's already been merged! I'd think that those changes wouldn't be picked up now.

Perhaps this needs another merge or rebase with main to make sure the latest things are in place?

@terrazoon
Copy link
Contributor Author

Weird that the notifications-python-client version bump is still in here when that's already been merged! I'd think that those changes wouldn't be picked up now.

Perhaps this needs another merge or rebase with main to make sure the latest things are in place?

I did another merge from main and another make bootstrap but it tells me I'm all up to date with nothing to change. I don't do rebase. :)

Copy link
Contributor

@ccostino ccostino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @terrazoon!

@ccostino ccostino merged commit 55dc017 into main Feb 27, 2024
5 checks passed
@ccostino ccostino deleted the notify-api-809 branch February 27, 2024 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Change error message to "Unavailable" when we can't find a phone number
2 participants