Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

800 flask command for test #828

Merged
merged 11 commits into from
Mar 5, 2024
Merged

800 flask command for test #828

merged 11 commits into from
Mar 5, 2024

Conversation

anagradova
Copy link
Contributor

Description

Added commands in commands.py to add users, orgs, jobs, notifications, and services to the test database. Corrected old default ".uk" strings in db.py

This should include:
#800
No visible changes.
No changes in dependencies.

TODO (optional)

Review commands to ensure they are flexible enough for needed future testing cases.

Security Considerations

All added commands should only execute in the testing database.

@anagradova anagradova linked an issue Mar 1, 2024 that may be closed by this pull request
3 tasks
@anagradova anagradova self-assigned this Mar 1, 2024
@ccostino ccostino requested a review from a team March 4, 2024 15:52
Copy link
Contributor

@terrazoon terrazoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code looks good. I'm not sure about who would run the commands or why. I wonder if there could be some documentation to prevent this from turning into a hidden feature no one knows is there, etc.

Copy link
Member

@A-Shumway42 A-Shumway42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is awesome. This allows us to put synthetic data into our local?

@anagradova
Copy link
Contributor Author

This is awesome. This allows us to put synthetic data into our local?

yes, it should. the commands are limited to test/dev.

Copy link
Contributor

@ccostino ccostino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @anagradova! This is awesome to see, and thank you for including the documentation! 🎉

There were just a few small things I saw for adjustment - let me know if you have anyway questions on them, and once they're taken care of we can merge!

app/commands.py Outdated Show resolved Hide resolved
app/commands.py Show resolved Hide resolved
docs/all.md Show resolved Hide resolved
Co-authored-by: Carlo Costino <ccostino@users.noreply.github.com>
Copy link
Contributor

@ccostino ccostino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @anagradova! 🎉

@ccostino ccostino merged commit df9ee47 into main Mar 5, 2024
5 checks passed
@ccostino ccostino deleted the 800-flask-command-for-test branch March 5, 2024 16:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Flask command for a likely job output
4 participants