-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
800 flask command for test #828
Conversation
Updated old .uk strings in db.py
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The code looks good. I'm not sure about who would run the commands or why. I wonder if there could be some documentation to prevent this from turning into a hidden feature no one knows is there, etc.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is awesome. This allows us to put synthetic data into our local?
yes, it should. the commands are limited to test/dev. |
documentation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, @anagradova! This is awesome to see, and thank you for including the documentation! 🎉
There were just a few small things I saw for adjustment - let me know if you have anyway questions on them, and once they're taken care of we can merge!
Co-authored-by: Carlo Costino <ccostino@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, @anagradova! 🎉
Description
Added commands in commands.py to add users, orgs, jobs, notifications, and services to the test database. Corrected old default ".uk" strings in db.py
This should include:
#800
No visible changes.
No changes in dependencies.
TODO (optional)
Review commands to ensure they are flexible enough for needed future testing cases.
Security Considerations
All added commands should only execute in the testing database.