Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove celery from notifications-utils (notify-api-130) #830

Merged
merged 4 commits into from
Mar 14, 2024

Conversation

terrazoon
Copy link
Contributor

Description

Only the notifications-api project uses celery, so remove it from the notifications-utils project and make the necessary changes so that celery is standalone in the notifications-api project.

This should include:

  • Links to issues that this PR addresses
  • Screenshots or screen captures of any visible changes, especially for UI work
  • Dependency changes

If there are any caveats, known issues, follow-up items, etc., make a quick note
of them here as well, though more details are probably warranted in the issue
itself in this case.

TODO

  • Be sure to merge this after merging the paired PR in the notifications-utils project

Security Considerations

N/A

@terrazoon terrazoon requested a review from ccostino March 4, 2024 18:34
@terrazoon terrazoon self-assigned this Mar 4, 2024
@terrazoon terrazoon linked an issue Mar 4, 2024 that may be closed by this pull request
@terrazoon terrazoon requested a review from a team March 4, 2024 18:35
pyproject.toml Outdated Show resolved Hide resolved
pyproject.toml Outdated Show resolved Hide resolved
Copy link
Contributor

@ccostino ccostino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @terrazoon!

@ccostino ccostino merged commit e89a6e5 into main Mar 14, 2024
5 checks passed
@ccostino ccostino deleted the notify-api-130 branch March 14, 2024 19:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Move Celery module from -utils to -api
2 participants