fix code coverage reporting #842
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Local testing has been failing for a while because code coverage was below 95% (it was being reported as 93%).
It turns out there are two big discrepancies between local code coverage testing and testing in the cloud.
In the cloud, coverage failed if it was below 50%. Coverage also EXCLUDED notifications-utils code.
Locally, coverage failed if it was below 95%, but it INCLUDED notifications-utils code.
If we exclude notifications-utils code, the true test coverage is 88%. So, set the fail threshold in the cloud temporarily to 87%, write a ticket to write more tests, and change the local coverage test to exclude notifications-utils while still failing if below 95%.
TODO
Security Considerations
N/A