-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
python upgrade updates #845
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In app/enums.py, the import for StrEnum
can be changed and the dependency on the strenum
can be removed with the conversion to Python 3.12.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Made a note below. Nothing major, just cleanup work. I'll mark it as approved, just please remove those comments.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It was supposed to mark as approved, but decided to say there were changes requested.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, @samathad2023! 🎉
Description
This is Draft PR aims to upgrade project to python version 3.12.2.This PR encompasses changes in dependencies, configurations and code modifications to ensure compatibility with Python 3.12.2 .This commit is used to test the Admin and API.
This should include:
install Python 3.12 via pyenv
pyenv install 3.12
Create the new virtual environment against 3.12
cd notifications-api pyenv virtualenv 3.12 notify-api-upgrade pyenv local notify-utils-upgrade
Update the project to use the new virtual env that is 3.12-based (in the project root directory,
pyenv local notify-api-upgrade
)Run
make bootstrap
to install the dependencies in the new virtual env