Fix remaining Terraform for production and demo #849
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This changeset adjusts our Terraform for the production and demo environments so that the new delete_recursive_allowed with the Cloud Foundry Cloud Controller is set to false. It also updates the shared modules to all explicitly account for this property so that we can set the flag easily. Signed-off-by: Carlo Costino <carlo.costino@gsa.gov>
|
Terraform Format and Style: success Show PlanPusher: @ccostino, Action: |
Signed-off-by: Carlo Costino <carlo.costino@gsa.gov>
|
Terraform Format and Style: success Show PlanPusher: @ccostino, Action: |
Signed-off-by: Carlo Costino <carlo.costino@gsa.gov>
|
Terraform Format and Style: success Show PlanPusher: @ccostino, Action: |
Signed-off-by: Carlo Costino <carlo.costino@gsa.gov>
|
Terraform Format and Style: success Show PlanPusher: @ccostino, Action: |
This will also ensure any drift is picked up by our infrastructure verification checks Signed-off-by: Carlo Costino <carlo.costino@gsa.gov>
|
Terraform Format and Style: success Show PlanPusher: @ccostino, Action: |
The SES and SNS modules are strictly for services that are instantiated within a space, while the egress_space is creating a separate space. The shift of the recursive delete from being on a service to being at the space level means that the SES and SNS modules do not have to track it at all, it should only be handled at the space level. The same goes for the allow_ssh flag. Signed-off-by: Carlo Costino <carlo.costino@gsa.gov>
|
Terraform Format and Style: success Show PlanPusher: @ccostino, Action: |
Signed-off-by: Carlo Costino <carlo.costino@gsa.gov>
|
Terraform Format and Style: success Show PlanPusher: @ccostino, Action: |
stvnrlly
approved these changes
Mar 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A note to PR reviewers: it may be helpful to review our code review documentation to know what to keep in mind while reviewing pull requests.
Description
This changeset adjusts our Terraform for the production and demo environments so that the new delete_recursive_allowed with the Cloud Foundry Cloud Controller is set to false. It also updates the shared modules to all explicitly account for this property so that we can set the flag easily.
Security Considerations
demoandproductionenvironments.